Add useTimestampForId option
ClosedPublic

Authored by Ottomata on Aug 1 2018, 2:17 PM.

Details

Reviewers
Pchelolo
Commits
rWKSE72a9e95ae136: Add useTimestampForId option
Patch without arc
git checkout -b D1090 && curl -L https://phabricator.wikimedia.org/D1090?download=true | git apply
Summary

This allows KafkaSSE to be configured to set the message timestamp
in each message event id, rather than offset. EventSource clients
will then provide the timestamps in their Last-Event-ID header
when reconnecting. Setting useTimestampForId better supports
multi datacenter EventStreams backed by multiple Kafka clusters
with topics populated by via tools like MirrorMaker.

Bug: T199433

Diff Detail

Repository
rWKSE KafkaSSE
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Ottomata created this revision.Aug 1 2018, 2:17 PM
Ottomata requested review of this revision.Aug 1 2018, 2:19 PM
Ottomata updated this revision to Diff 2860.Aug 1 2018, 2:19 PM
  • Bump to version 0.3.0
Pchelolo accepted this revision.Aug 1 2018, 2:26 PM
This revision is now accepted and ready to land.Aug 1 2018, 2:26 PM
This revision was automatically updated to reflect the committed changes.