Differential D1090

Add useTimestampForId option
ClosedPublic
Actions

Authored by Ottomata on Aug 1 2018, 2:17 PM.

Details

Reviewers

Pchelolo

Commits

rWKSE72a9e95ae136: Add useTimestampForId option

Patch without arc

git checkout -b D1090 && curl -L https://phabricator.wikimedia.org/D1090?download=true | git apply

Summary

This allows KafkaSSE to be configured to set the message timestamp
in each message event id, rather than offset. EventSource clients
will then provide the timestamps in their Last-Event-ID header
when reconnecting. Setting useTimestampForId better supports
multi datacenter EventStreams backed by multiple Kafka clusters
with topics populated by via tools like MirrorMaker.

Bug: T199433

Diff Detail

Repository

rWKSE KafkaSSE

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Ottomata created this revision.Aug 1 2018, 2:17 PM

Harbormaster completed remote builds in B3080: Diff 2859.Aug 1 2018, 2:19 PM

Ottomata requested review of this revision.Aug 1 2018, 2:19 PM

Bump to version 0.3.0

Ottomata added a reviewer: Pchelolo.Aug 1 2018, 2:20 PM

Harbormaster completed remote builds in B3081: Diff 2860.Aug 1 2018, 2:22 PM

Pchelolo accepted this revision.Aug 1 2018, 2:26 PM

This revision is now accepted and ready to land.Aug 1 2018, 2:26 PM

Closed by commit rWKSE72a9e95ae136: Add useTimestampForId option (authored by Ottomata). · Explain WhyAug 1 2018, 2:33 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			README.md (16 lines)
M			lib/KafkaSSE.js (18 lines)
M			package.json (2 lines)
M			server.js (3 lines)
M			test/KafkaSSE.js (46 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2859	fe0df0e		Aug 1 2018, 2:17 PM	★	★
Diff 2	2860	fe0df0e	- Bump to version 0.3.0	Aug 1 2018, 2:19 PM	★	★
Diff 3	2861	fe0df0e	rWKSE72a9e95ae1361cba9508042b15c0a457c71ee0b6	Aug 1 2018, 2:29 PM	★	★