Differential D1100

sync-wikiversion: don't overwrite AbstractSync
ClosedPublic
Actions

Authored by thcipriani on Aug 22 2018, 5:43 PM.

Tags

Subscribers

None

Details

Reviewers

mmodell
dduvall
• bd808

Group Reviewers

Release-Engineering-Team

Commits

rMSCA35e4dc6ea855: sync-wikiversion: don't overwrite AbstractSync

Patch without arc

git checkout -b D1100 && curl -L https://phabricator.wikimedia.org/D1100?download=true | git apply

Summary

sync-wikiversions implements AbstractSync, but overwrites the main
method which clobbers much of the logic of AbstractSync. We ran into a
problem when AbstractSync was extended to include logic to sync masters.
Now AbstractSync supports canaries but sync-wikiversions does not.

Rather than add-in canary support for sync-wikiversions, I've opted to
have sync-wikiversions use AbstractSync's main method. This means that
sync-wikiversions will perform sync-masters, canary and proxy fan-out
steps which will make it slower, but hopefully safer.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Aug 22 2018, 5:43 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptAug 22 2018, 5:43 PM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster completed remote builds in B3094: Diff 2876.Aug 22 2018, 5:46 PM

thcipriani requested review of this revision.Aug 22 2018, 5:46 PM

I don't like making sync-wikiversions slower but I suppose safer is important ;)

This revision is now accepted and ready to land.Aug 23 2018, 1:11 AM

Closed by commit rMSCA35e4dc6ea855: sync-wikiversion: don't overwrite AbstractSync (authored by thcipriani). · Explain WhyAug 24 2018, 7:19 PM

This revision was automatically updated to reflect the committed changes.

thcipriani mentioned this in T198640: Perform scap canary checks after sync-wikiversions.Aug 27 2018, 3:05 PM

Revision Contents
Changeset List

			Path	Packages
M			scap/main.py (37 lines)

Diff 2878

scap/main.py

Loading...