sync-wikiversion: don't overwrite AbstractSync
ClosedPublic

Authored by thcipriani on Aug 22 2018, 5:43 PM.

Details

Reviewers
mmodell
dduvall
bd808
Group Reviewers
Release-Engineering-Team
Commits
rMSCA35e4dc6ea855: sync-wikiversion: don't overwrite AbstractSync
Patch without arc
git checkout -b D1100 && curl -L https://phabricator.wikimedia.org/D1100?download=true | git apply
Summary

sync-wikiversions implements AbstractSync, but overwrites the main
method which clobbers much of the logic of AbstractSync. We ran into a
problem when AbstractSync was extended to include logic to sync masters.
Now AbstractSync supports canaries but sync-wikiversions does not.

Rather than add-in canary support for sync-wikiversions, I've opted to
have sync-wikiversions use AbstractSync's main method. This means that
sync-wikiversions will perform sync-masters, canary and proxy fan-out
steps which will make it slower, but hopefully safer.

Bug: T198640

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thcipriani created this revision.Aug 22 2018, 5:43 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptAug 22 2018, 5:43 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Aug 22 2018, 5:46 PM
mmodell accepted this revision.Aug 23 2018, 1:11 AM

I don't like making sync-wikiversions slower but I suppose safer is important ;)

This revision is now accepted and ready to land.Aug 23 2018, 1:11 AM
This revision was automatically updated to reflect the committed changes.