Add --force to AbstractSync
ClosedPublic

Authored by thcipriani on Aug 28 2018, 6:04 PM.

Details

Reviewers
mmodell
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rMSCA8bd680cf1a51: Add --force to AbstractSync
Patch without arc
git checkout -b D1102 && curl -L https://phabricator.wikimedia.org/D1102?download=true | git apply
Summary

Since AbstractSync refers to self.arguments.force in the methods of the
class.

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
thcipriani created this revision.Aug 28 2018, 6:04 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptAug 28 2018, 6:04 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Aug 28 2018, 6:07 PM
mmodell accepted this revision.Aug 28 2018, 9:17 PM
This revision is now accepted and ready to land.Aug 28 2018, 9:17 PM

Should we be sure to log that canary checks were skipped?

mmodell added inline comments.Aug 28 2018, 9:21 PM
scap/main.py
85
else:
    self.get_logger().warning('Canaries Skipped by --force')
thcipriani updated this revision to Diff 2881.Aug 28 2018, 9:23 PM

Log when --force is used

thcipriani marked an inline comment as done.Aug 28 2018, 9:24 PM
mmodell accepted this revision.Aug 28 2018, 9:24 PM

lgtm :)

This revision was automatically updated to reflect the committed changes.