Add --force to AbstractSync
ClosedPublic
Actions

Authored by thcipriani on Aug 28 2018, 6:04 PM.

Details

Reviewers

mmodell
dduvall

Group Reviewers

Release-Engineering-Team

Commits

rMSCA8bd680cf1a51: Add --force to AbstractSync

Patch without arc

git checkout -b D1102 && curl -L https://phabricator.wikimedia.org/D1102?download=true | git apply

Summary

Since AbstractSync refers to self.arguments.force in the methods of the
class.

Repository

rMSCA Scap

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

thcipriani requested review of this revision.Aug 28 2018, 6:07 PM

This revision is now accepted and ready to land.Aug 28 2018, 9:17 PM

Should we be sure to log that canary checks were skipped?

scap/main.py
85	else: self.get_logger().warning('Canaries Skipped by --force')

Log when --force is used

thcipriani marked an inline comment as done.Aug 28 2018, 9:24 PM

lgtm :)

This revision was automatically updated to reflect the committed changes.

			Path	Packages
M			scap/main.py (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2879	35e4dc6		Aug 28 2018, 6:04 PM	★	★
Diff 2	2881	35e4dc6	Log when --force is used	Aug 28 2018, 9:23 PM	★	★
Diff 3	2882	35e4dc6	rMSCA8bd680cf1a51c29ab355ad192d83924d5e0db1ab	Aug 28 2018, 9:27 PM	★	★