Differential D1102

Add --force to AbstractSync
ClosedPublic
Actions

Authored by • thcipriani on Aug 28 2018, 6:04 PM.

Tags

Subscribers

None

Details

Reviewers

mmodell
dduvall

Group Reviewers

Release-Engineering-Team

Commits

rMSCA8bd680cf1a51: Add --force to AbstractSync

Patch without arc

git checkout -b D1102 && curl -L https://phabricator.wikimedia.org/D1102?download=true | git apply

Summary

Since AbstractSync refers to self.arguments.force in the methods of the
class.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

• thcipriani created this revision.Aug 28 2018, 6:04 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptAug 28 2018, 6:04 PM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster completed remote builds in B3096: Diff 2879.Aug 28 2018, 6:07 PM

• thcipriani requested review of this revision.Aug 28 2018, 6:07 PM

mmodell accepted this revision.Aug 28 2018, 9:17 PM

This revision is now accepted and ready to land.Aug 28 2018, 9:17 PM

Should we be sure to log that canary checks were skipped?

mmodell added inline comments.Aug 28 2018, 9:21 PM

scap/main.py
85	else: self.get_logger().warning('Canaries Skipped by --force')

Log when --force is used

• thcipriani marked an inline comment as done.Aug 28 2018, 9:24 PM

lgtm :)

Harbormaster completed remote builds in B3098: Diff 2881.Aug 28 2018, 9:26 PM

Closed by commit rMSCA8bd680cf1a51: Add --force to AbstractSync (authored by • thcipriani). · Explain WhyAug 28 2018, 9:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			scap/main.py (3 lines)

Diff 2882

scap/main.py

Loading...