Page MenuHomePhabricator

Add --force to AbstractSync
ClosedPublic

Authored by thcipriani on Aug 28 2018, 6:04 PM.

Details

Reviewers
mmodell
dduvall
Group Reviewers
Release-Engineering-Team
Commits
rMSCA8bd680cf1a51: Add --force to AbstractSync
Patch without arc
git checkout -b D1102 && curl -L https://phabricator.wikimedia.org/D1102?download=true | git apply
Summary

Since AbstractSync refers to self.arguments.force in the methods of the
class.

Diff Detail

Repository
rMSCA Scap
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 28 2018, 9:17 PM

Should we be sure to log that canary checks were skipped?

scap/main.py
85
else:
    self.get_logger().warning('Canaries Skipped by --force')
This revision was automatically updated to reflect the committed changes.