Page MenuHomePhabricator
Differential D1104

Specify transparent -extent background for RGBA images
ClosedPublic
Actions

Authored by Gilles on Aug 29 2018, 8:27 AM.

Details

Maniphest Tasks
T198370: Transparent background renders as white in PNG thumbnails
Reviewers
fgiunchedi
Commits
rTHMBREXT399b6890c8d8: Specify transparent -extent background for RGBA images
Patch without arc
git checkout -b D1104 && curl -L https://phabricator.wikimedia.org/D1104?download=true | git apply
Summary

Refs T198370

Diff Detail

Repository
rTHMBREXT Thumbor Plugins
Branch
T198370 (branched from master)
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 3102
Build 5189: differential-jessieJenkins
Build 5188: arc lint + arc unit

Event Timeline

Gilles created this revision.Aug 29 2018, 8:27 AM
Harbormaster completed remote builds in B3101: Diff 2884.Aug 29 2018, 8:28 AM
Gilles requested review of this revision.Aug 29 2018, 8:28 AM
Gilles updated this revision to Diff 2885.Aug 29 2018, 8:33 AM

Tweak xcf webp test size threshold

Harbormaster completed remote builds in B3102: Diff 2885.Aug 29 2018, 8:34 AM
fgiunchedi accepted this revision.Aug 29 2018, 12:58 PM

LGTM, I take it on newer IM this isn't going to hurt either.

This revision is now accepted and ready to land.Aug 29 2018, 12:58 PM
Closed by commit rTHMBREXT399b6890c8d8: Specify transparent -extent background for RGBA images (authored by Gilles). · Explain WhyAug 29 2018, 1:57 PM
This revision was automatically updated to reflect the committed changes.
Gilles mentioned this in rTHMBREXTe15d36451e52: Version bump.Aug 29 2018, 2:04 PM

Revision Contents
Changeset List

PathSize
tests/
integration/
2 lines
2 lines
wikimedia_thumbor/
engine/
imagemagick/
5 lines

Diff 2885

View Options

tests/integration/test_png.py

Loading...
View Options

tests/integration/test_xcf.py

Loading...
View Options

wikimedia_thumbor/engine/imagemagick/imagemagick.py

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL