Differential D1110

Add ability to specify PHP version for scap
ClosedPublic
Actions

Authored by thcipriani on Sep 6 2018, 8:11 PM.

Details

Reviewers

• mmodell

Group Reviewers

Release-Engineering-Team

Commits

rMSCA36d2144d2453: Add ability to specify PHP version for scap

Patch without arc

git checkout -b D1110 && curl -L https://phabricator.wikimedia.org/D1110?download=true | git apply

Summary

Allows user to specify php version for scap via scap.cfg. By default
this is "php", but it will allow updates to the configuration in puppet
to enable PHP="hhvm Eval.Jit=1" for performance improvements to
rebuildLocalisationCahce.php.

The scap configuration in puppet should be updated after this is made
live. As part of the migration to php7 the configuration in puppet will,
again, need to be modified.

Bug: T203680

Diff Detail

Repository

rMSCA Scap

Branch

master

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 3115
Build 5208: docker-diffs	Jenkins
Build 5207: differential-jessie	Jenkins
Build 5206: arc lint + arc unit

Event Timeline

thcipriani created this revision.Sep 6 2018, 8:11 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptSep 6 2018, 8:11 PM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

cahce -> cache

Harbormaster completed remote builds in B3114: Diff 2895.Sep 6 2018, 8:15 PM

Harbormaster completed remote builds in B3115: Diff 2896.

thcipriani requested review of this revision.Sep 6 2018, 8:15 PM

• mmodell accepted this revision.Sep 6 2018, 9:42 PM

This revision is now accepted and ready to land.Sep 6 2018, 9:42 PM

Closed by commit rMSCA36d2144d2453: Add ability to specify PHP version for scap (authored by thcipriani). · Explain WhySep 7 2018, 6:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

	Path	Coverage (All)	Coverage (Touched)
M	scap/cli.py (3 lines)	0%	Loading...
M	scap/config.py (1 line)	0%	Loading...
M	scap/utils.py (2 lines)	0%	Loading...

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2895	9a2d81e		Sep 6 2018, 8:11 PM	★	★
Diff 2	2896	9a2d81e	cahce -> cache	Sep 6 2018, 8:13 PM	★	★
Diff 3	2897	9a2d81e	rMSCA36d2144d2453d352bf09453291aa0683a60fdbf6	Sep 7 2018, 6:20 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
64521407b827	ebd38c4406cd	9a2d81e1c5ca	Tyler Cipriani	Add ability to specify PHP version for scap (Show More…)	Sep 6 2018, 8:02 PM

Diff 2896

View Options

scap/cli.py

View Options

scap/config.py

View Options

Add ability to specify PHP version for scapClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2896

scap/cli.py

scap/config.py

scap/utils.py

Add ability to specify PHP version for scap
ClosedPublic
Actions

Revision Contents
Changeset List