Paths

Table of Contentst

Differential D1110

Add ability to specify PHP version for scap
ClosedPublic
Actions

Authored by thcipriani on Sep 6 2018, 8:11 PM.

Tags

Subscribers

None

Details

Reviewers

Group Reviewers

Release-Engineering-Team

Commits

rMWc9b4abef2e6b: Update patch set 1
rMSCA36d2144d2453: Add ability to specify PHP version for scap

Patch without arc

git checkout -b D1110 && curl -L https://phabricator.wikimedia.org/D1110?download=true | git apply

Summary

Allows user to specify php version for scap via scap.cfg. By default
this is "php", but it will allow updates to the configuration in puppet
to enable PHP="hhvm Eval.Jit=1" for performance improvements to
rebuildLocalisationCahce.php.

The scap configuration in puppet should be updated after this is made
live. As part of the migration to php7 the configuration in puppet will,
again, need to be modified.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3115
Build 5208: docker-diffs	Jenkins
Build 5207: differential-jessie	Jenkins
Build 5206: arc lint + arc unit

Event Timeline

thcipriani created this revision.Sep 6 2018, 8:11 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptSep 6 2018, 8:11 PM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

cahce -> cache

Harbormaster completed remote builds in B3114: Diff 2895.Sep 6 2018, 8:15 PM

Harbormaster completed remote builds in B3115: Diff 2896.

thcipriani requested review of this revision.Sep 6 2018, 8:15 PM

mmodell accepted this revision.Sep 6 2018, 9:42 PM

This revision is now accepted and ready to land.Sep 6 2018, 9:42 PM

Closed by commit rMSCA36d2144d2453: Add ability to specify PHP version for scap (authored by thcipriani). · Explain WhySep 7 2018, 6:22 PM

This revision was automatically updated to reflect the committed changes.

• satoshinakamoto added a commit: rMWc9b4abef2e6b: Update patch set 1.Dec 20 2021, 5:33 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

scap/

3 lines

0%

Loading...

1 line

0%

Loading...

2 lines

0%

Loading...

Diff 2896

scap/cli.py

Loading...

scap/config.py

Loading...

scap/utils.py

Loading...