Change message to 'Copying from x to y'
ClosedPublic
Actions

Authored by hashar on Sep 14 2018, 2:25 PM.

Details

Reviewers

mmodell
thcipriani

Group Reviewers

Release-Engineering-Team

Commits

rMWc9b4abef2e6b: Update patch set 1
rMSCA10b80cba36ac: Change message to 'Copying from x to y'

Patch without arc

git checkout -b D1112 && curl -L https://phabricator.wikimedia.org/D1112?download=true | git apply

Summary

scap pull message 'Copying to xxx from yyy' sounds upside down to me, I
keep misleading the intent is to copy to xxx.

Flip it to have the source first and the destination last:
Copying from yyyy to xxxx

Diff Detail

Repository

rMSCA Scap

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hashar created this revision.Sep 14 2018, 2:25 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptSep 14 2018, 2:25 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 14 2018, 2:26 PM

Harbormaster failed remote builds in B3121: Diff 2901!

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

doc develop-inst: /srv/jenkins-workspace/workspace/phabricator-jessie-diffs
  /srv/jenkins-workspace/workspace/phabricator-jessie-diffs$ /srv/jenkins-workspace/workspace/phabricator-jessie-diffs/.tox/doc/bin/pip install -e /srv/jenkins-workspace/workspace/phabricator-jessie-diffs >/srv/jenkins-workspace/workspace/phabricator-jessie-diffs/.tox/doc/log/doc-2.log
  /srv/jenkins-workspace/workspace/phabricator-jessie-diffs$ /srv/jenkins-workspace/workspace/phabricator-jessie-diffs/.tox/doc/bin/pip freeze >/srv/jenkins-workspace/workspace/phabricator-jessie-diffs/.tox/doc/log/doc-3.log
doc installed: actdiag==0.5.4,alabaster==0.7.11,argh==0.26.2,Babel==2.6.0,backports-abc==0.5,blockdiag==1.5.4,certifi==2018.8.24,chardet==3.0.4,configparser==3.5.0,conftool==1.0.2,dnspython==1.15.0,docutils==0.14,funcparserlib==0.3.6,functools32==3.2.3.post2,futures==3.2.0,idna==2.7,imagesize==1.1.0,Jinja2==2.10,jsonschema==2.6.0,livereload==2.5.2,MarkupSafe==1.0,packaging==17.1,pathtools==0.1.2,Pillow==5.2.0,port-for==0.3.1,psutil==5.4.7,pyaml==17.12.1,Pygments==2.2.0,pyparsing==2.2.0,python-etcd==0.4.5,pytz==2018.5,PyYAML==3.13,requests==2.19.1,-e git+https://phabricator.wikimedia.org/source/scap.git@db590f5529400bbdbaae6912c1d386342ad9f53f#egg=Scap,singledispatch==3.4.0.3,six==1.11.0,snowballstemmer==1.2.1,Sphinx==1.8.0,sphinx-autobuild==0.7.1,sphinxcontrib-actdiag==0.8.5,sphinxcontrib-blockdiag==1.5.5,sphinxcontrib-programoutput==0.11,sphinxcontrib-websupport==1.1.0,tornado==5.1,typing==3.6.6,urllib3==1.23,watchdog==0.9.0,webcolors==1.8.1
doc runtests: PYTHONHASHSEED='2644240908'
doc runtests: commands[0] | sphinx-build -W -b html docs/ docs/_build/html
  /srv/jenkins-workspace/workspace/phabricator-jessie-diffs$ /srv/jenkins-workspace/workspace/p


Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1155/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1155/console

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/517/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/517/console

@mmodell and @thcipriani can you look at this one please? It is puzzling me :)

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
  py27: commands succeeded
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
ERROR:   flake8: commands failed
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1186/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1186/console

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/542/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/542/console

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/differential-docker-test/544/
See console output for more information: https://integration.wikimedia.org/ci/job/differential-docker-test/544/console

Build has FAILED

	Test Name
	tox -v	Build Details

tox -v log

Got exit code 1 from PY_COLORS=1 tox -v

highlighting module code... [ 95%] scap.utils
highlighting module code... [100%] time

writing additional pages... search
copying images... [100%] assets/images/deploy-log.gif

copying static files... done
copying extra files... done
dumping search index in English (code: en) ... done
dumping object inventory... done
build succeeded.

The HTML pages are in docs/_build/html.
___________________________________ summary ____________________________________
  py27: commands succeeded
  py34: ignored failed command
SKIPPED:  py35: InterpreterNotFound: python3.5
SKIPPED:  py36: InterpreterNotFound: python3.6
ERROR:   flake8: commands failed
  doc: commands succeeded

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1188/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/1188/console