Page MenuHomePhabricator

Remove '/' from include in sync-wikiversions
ClosedPublic

Authored by thcipriani on Oct 23 2018, 6:25 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA1b4b1f84401c: Remove '/' from include in sync-wikiversions
Patch without arc
git checkout -b D1120 && curl -L https://phabricator.wikimedia.org/D1120?download=true | git apply
Summary

When combined with the code in sync_common this results in a double
/ (i.e., --include=//wikiversions*.{json,php}) which means that
wikiversions.{json,php} is not kept in sync with the staging directory
on the deployment masters. This affects the accuracy of
scap wikiversions-inuse.

Bug: T207602

Diff Detail

Repository
rMSCA Scap
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2018, 6:25 PM
Harbormaster failed remote builds in B3150: Diff 2922!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2018, 8:08 PM
Harbormaster failed remote builds in B3151: Diff 2923!
This revision is now accepted and ready to land.Oct 23 2018, 10:13 PM
This revision was automatically updated to reflect the committed changes.