Paths

Table of Contentst

Differential D1120

Remove '/' from include in sync-wikiversions
ClosedPublic
Actions

Authored by thcipriani on Oct 23 2018, 6:25 PM.

Tags

Referenced Files

	Unknown Object (File)
	Mar 20 2023, 11:16 AM

	Unknown Object (File)
	Mar 16 2023, 11:36 PM

	Unknown Object (File)
	Mar 15 2023, 2:57 PM

	Unknown Object (File)
	Mar 11 2023, 12:51 AM

	Unknown Object (File)
	Mar 10 2023, 3:25 PM

	Unknown Object (File)
	Mar 5 2023, 2:04 PM

	Unknown Object (File)
	Mar 4 2023, 11:28 AM

	Unknown Object (File)
	Feb 26 2023, 10:12 AM

View All 21 Files

Subscribers

Details

Reviewers

Group Reviewers

Release-Engineering-Team

Commits

rMWc9b4abef2e6b: Update patch set 1
rMSCA1b4b1f84401c: Remove '/' from include in sync-wikiversions

Patch without arc

git checkout -b D1120 && curl -L https://phabricator.wikimedia.org/D1120?download=true | git apply

Summary

When combined with the code in sync_common this results in a double
/ (i.e., --include=//wikiversions*.{json,php}) which means that
wikiversions.{json,php} is not kept in sync with the staging directory
on the deployment masters. This affects the accuracy of
scap wikiversions-inuse.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 3151
Build 5277: docker-diffs	Jenkins
Build 5276: differential-jessie	Jenkins
Build 5275: arc lint + arc unit

Event Timeline

thcipriani created this revision.Oct 23 2018, 6:25 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptOct 23 2018, 6:25 PM

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2018, 6:25 PM

Harbormaster failed remote builds in B3150: Diff 2922!

thcipriani mentioned this in T207602: deploy1001:/srv/mediawiki out of date?.Oct 23 2018, 6:26 PM

Recheck

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 23 2018, 8:08 PM

Harbormaster failed remote builds in B3151: Diff 2923!

Harbormaster completed remote builds in B3151: Diff 2923.Oct 23 2018, 10:01 PM

thcipriani requested review of this revision.Oct 23 2018, 10:01 PM

mmodell accepted this revision.Oct 23 2018, 10:13 PM

This revision is now accepted and ready to land.Oct 23 2018, 10:13 PM

Closed by commit rMSCA1b4b1f84401c: Remove '/' from include in sync-wikiversions (authored by thcipriani). · Explain WhyOct 24 2018, 3:12 PM

This revision was automatically updated to reflect the committed changes.

• satoshinakamoto added a commit: rMWc9b4abef2e6b: Update patch set 1.Dec 20 2021, 5:33 PM

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

scap/

2 lines

0%

Loading...

Diff 2923

scap/main.py

Loading...