Fix the check for is_admin in LegalpadDocumentRequireSignatureTransaction
ClosedPublic
Actions

Authored by mmodell on Oct 29 2018, 9:51 PM.

Details

Maniphest Tasks

T208254: Legalpad access controls are confusing and seemingly broken

Reviewers

JeanFred
Dzahn
mmodell

Commits

rPHABaec846f37b26: Fix the check for is_admin in LegalpadDocumentRequireSignatureTransaction

Patch without arc

git checkout -b D1123 && curl -L https://phabricator.wikimedia.org/D1123?download=true | git apply

Summary

We don't want to check is_admin if we aren't actually settting the doc
to require signature. refs T208254

Bug: T208254

Test Plan

tested on my local phab instance

Diff Detail

Repository

rPHAB Phabricator

Branch

wmf/stable

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 3156
Build 5284: arc lint + arc unit

Event Timeline

mmodell requested review of this revision.Oct 29 2018, 9:51 PM

mmodell created this revision.

Harbormaster completed remote builds in B3155: Diff 2928.Oct 29 2018, 9:51 PM

much improved validation.

Harbormaster completed remote builds in B3156: Diff 2929.Oct 30 2018, 12:12 AM

self-reviewing since there aren't any qualified phabricator reviewers available.

This revision is now accepted and ready to land.Oct 30 2018, 8:14 PM

Dzahn awarded a token.Oct 30 2018, 8:23 PM

committed rPHABaec846f37b26: Fix the check for is_admin in LegalpadDocumentRequireSignatureTransaction and cherry-picked on phab1001

epriestley mentioned this in T208254: Legalpad access controls are confusing and seemingly broken.Mar 26 2019, 4:30 PM

Revision Contents
Changeset List

			Path	Packages
M			src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2928	0c864b8		Oct 29 2018, 9:51 PM	★	★
Diff 2	2929	0c864b8	much improved validation.	Oct 30 2018, 12:12 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
aec846f37b26	d6b24deb8d09	0c864b875f67	Mukunda Modell	Fix the check for is_admin in LegalpadDocumentRequireSignatureTransaction (Show More…)	Oct 29 2018, 9:44 PM

Diff 2929

View Options

src/applications/legalpad/xaction/LegalpadDocumentRequireSignatureTransaction.php

Fix the check for is_admin in LegalpadDocumentRequireSignatureTransactionClosedPublicActions