Fix the check for is_admin in LegalpadDocumentRequireSignatureTransaction
ClosedPublic

Authored by mmodell on Oct 29 2018, 9:51 PM.

Details

Maniphest Tasks
T208254: Legalpad access controls are confusing and seemingly broken
Reviewers
JeanFred
Dzahn
mmodell
Commits
rPHABaec846f37b26: Fix the check for is_admin in LegalpadDocumentRequireSignatureTransaction
Patch without arc
git checkout -b D1123 && curl -L https://phabricator.wikimedia.org/D1123?download=true | git apply
Summary

We don't want to check is_admin if we aren't actually settting the doc
to require signature. refs T208254

Bug: T208254

Test Plan

tested on my local phab instance

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 3156
Build 5284: arc lint + arc unit
mmodell requested review of this revision.Oct 29 2018, 9:51 PM
mmodell created this revision.
mmodell updated this revision to Diff 2929.Oct 30 2018, 12:12 AM

much improved validation.

mmodell accepted this revision.Oct 30 2018, 8:14 PM

self-reviewing since there aren't any qualified phabricator reviewers available.

This revision is now accepted and ready to land.Oct 30 2018, 8:14 PM
Dzahn awarded a token.Oct 30 2018, 8:23 PM