Redact key from error messages.
AcceptedPublic

Authored by Samwilson on Nov 1 2018, 1:44 AM.

Details

Reviewers
MusikAnimal
MaxSem
aezell
kaldari
Commits
R1966:529bbf4f1399: Redact key from error messages.
Patch without arc
git checkout -b D1124 && curl -L https://phabricator.wikimedia.org/D1124?download=true | git apply
Summary

Bug: T208374

Diff Detail

Repository
R1966 tool-ws-google-ocr
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3158
Build 5286: arc lint + arc unit
Samwilson requested review of this revision.Nov 1 2018, 1:44 AM
Samwilson created this revision.
MaxSem added inline comments.Nov 1 2018, 2:04 AM
src/Ocr.php
77

I don't like that stack trace will be lost here.

Samwilson updated this revision to Diff 2931.Nov 1 2018, 3:48 AM
  • Include previous exception
Samwilson marked an inline comment as done.Nov 1 2018, 3:50 AM
Samwilson added inline comments.
src/Ocr.php
77

Yeah, me neither. I meant to at least put the previous exception. Done now.

I'm pretty sure there's a better way of doing what we want here, but I didn't want to spend too long on this. :)

Shall we re-write in Symfony?

Samwilson marked an inline comment as done.Nov 1 2018, 3:51 AM
kaldari accepted this revision.Nov 1 2018, 10:40 PM
This revision is now accepted and ready to land.Nov 1 2018, 10:40 PM