Paths

Table of Contentst

Differential D1126

Fix ascii art regression
ClosedPublic
Actions

Authored by thcipriani on Nov 7 2018, 5:47 PM.

Details

Reviewers

mmodell

Group Reviewers

Release-Engineering-Team

Commits

rMSCA60b2cc96ca83: Fix ascii art regression

Patch without arc

git checkout -b D1126 && curl -L https://phabricator.wikimedia.org/D1126?download=true | git apply

Test Plan

scap say 'this works again'

Diff Detail

Repository

rMSCA Scap

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Nov 7 2018, 5:47 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptNov 7 2018, 5:47 PM

Restricted Application added a reviewer: Release-Engineering-Team. · View Herald Transcript

Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Harbormaster completed remote builds in B3167: Diff 2934.Nov 7 2018, 5:48 PM

thcipriani requested review of this revision.Nov 7 2018, 5:48 PM

mmodell accepted this revision.Nov 7 2018, 5:49 PM

This revision is now accepted and ready to land.Nov 7 2018, 5:49 PM

Closed by commit rMSCA60b2cc96ca83: Fix ascii art regression (authored by thcipriani). · Explain WhyNov 7 2018, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scap/

ansi.py

23 lines

plugins/

say.py

8 lines

Diff 2935

View Options

scap/ansi.py