Page MenuHomePhabricator

Python3 compatibility
ClosedPublic

Authored by thcipriani on Dec 20 2018, 8:06 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA6e9c935a5196: Python3 compatibility
Patch without arc
git checkout -b D1131 && curl -L https://phabricator.wikimedia.org/D1131?download=true | git apply
Summary

The test suite now passes for python2 and python3 with the exception on
the cdblibrary which will require some deeper testing.

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

thcipriani created this revision.Dec 20 2018, 8:06 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptDec 20 2018, 8:06 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Dec 20 2018, 8:09 PM
mmodell accepted this revision.Dec 20 2018, 9:39 PM

Looks good.

I attempted to review all other uses of the divide operator. I don't think there are any others that will be problematic.

This revision is now accepted and ready to land.Dec 20 2018, 9:39 PM
This revision was automatically updated to reflect the committed changes.