Fix bad migration for closerPHID
AcceptedPublic

Authored by bd808 on Wed, Jan 2, 2:13 AM.

Details

Reviewers
mmodell
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Patch without arc
git checkout -b D1134 && curl -L https://phabricator.wikimedia.org/D1134?download=true | git apply
Summary

Follow up to 447032e that fixes an SQL statement syntax error in the
database migration that adds the closerPHID column for manifest tasks.

Diff Detail

Repository
rPHAB Phabricator
Branch
fix-closerPHID-migration
Lint
Lint ErrorsExcuse: Unrelated lint errors when running `arc diff` from my dev environment
SeverityLocationCodeMessage
Errorsrc/applications/calendar/controller/PhabricatorCalendarEventViewController.php:468PHL1Unknown Symbol
Errorsrc/applications/calendar/import/PhabricatorCalendarICSImportEngine.php:11PHL1Unknown Symbol
Errorsrc/applications/calendar/import/PhabricatorCalendarICSImportEngine.php:15PHL1Unknown Symbol
Errorsrc/applications/calendar/query/PhabricatorCalendarEventQuery.php:717PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:110PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:134PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:333PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:473PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:789PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:822PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:905PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:977PHL1Unknown Symbol
Errorsrc/applications/calendar/storage/PhabricatorCalendarEvent.php:1030PHL1Unknown Symbol
Errorsrc/applications/calendar/util/PhabricatorCalendarICSWriter.php:46PHL1Unknown Symbol
Errorsrc/applications/calendar/util/PhabricatorCalendarICSWriter.php:54PHL1Unknown Symbol
Errorsrc/applications/calendar/util/PhabricatorCalendarICSWriter.php:57PHL1Unknown Symbol
Errorsrc/applications/calendar/xaction/PhabricatorCalendarEventAllDayTransaction.php:32PHL1Unknown Symbol
Errorsrc/applications/calendar/xaction/PhabricatorCalendarEventDateTransaction.php:48PHL1Unknown Symbol
Errorsrc/applications/calendar/xaction/PhabricatorCalendarEventEndDateTransaction.php:21PHL1Unknown Symbol
Errorsrc/applications/calendar/xaction/PhabricatorCalendarEventFrequencyTransaction.php:19PHL1Unknown Symbol
Errorsrc/applications/calendar/xaction/PhabricatorCalendarEventStartDateTransaction.php:21PHL1Unknown Symbol
Errorsrc/applications/calendar/xaction/PhabricatorCalendarEventUntilDateTransaction.php:27PHL1Unknown Symbol
Errorsrc/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemonModule.php:8PHL1Unknown Symbol
Errorsrc/applications/repository/engine/PhabricatorRepositoryPullEngine.php:493PHL1Unknown Symbol
Errorsrc/view/form/control/AphrontFormDateControlValue.php:243PHL1Unknown Symbol
Unit
No Unit Test Coverage
Build Status
Buildable 3187
Build 5323: arc lint + arc unit
bd808 created this revision.Wed, Jan 2, 2:13 AM
Restricted Application added a reviewer: Restricted Owners Package.Wed, Jan 2, 2:13 AM
Restricted Application added a reviewer: mmodell. · View Herald TranscriptWed, Jan 2, 2:13 AM
bd808 requested review of this revision.Wed, Jan 2, 2:13 AM
hashar added a subscriber: hashar.Wed, Jan 2, 9:30 AM

The patch is for Phabricator Feb 2018 update, I cant tell though whether our database had phabricator_maniphest.maniphest_task.closerPHIDcreated. Hopefully it has been fixed manually.

That is interesting, yesterday I looked at the project burn-up chart for one project which are broken (due to migrated bug not considered being closed). Only to wake up this morning and find this patch in my email inbox...
So that seems to related to T107254: Closed tickets in Bugzilla migrated without closing event?, one of the symptom being T119376: Maniphest burnup report incorrectly counts "All Time" opened and closed tasks. Which I guess are fixable by populating the closerPHID and closedEpoch fields.

mmodell accepted this revision.Mon, Jan 7, 10:03 PM
This revision is now accepted and ready to land.Mon, Jan 7, 10:03 PM