Page MenuHomePhabricator

lockfile: python2/3 compat
ClosedPublic

Authored by thcipriani on Jan 7 2019, 3:31 PM.

Details

Reviewers
mmodell
ATIFAND
Group Reviewers
Release-Engineering-Team
Commits
rMSCA1a402b445474: lockfile: python2/3 compat
Patch without arc
git checkout -b D1137 && curl -L https://phabricator.wikimedia.org/D1137?download=true | git apply
Summary

Ensure that filenames are binary, files are read to and from as binary,
and that, prior to writing to or from files, they internal messages are
unicode.

When writing a filename to stdout, it should be unicode.

This commit is based on D1136.

Diff Detail

Event Timeline

thcipriani created this revision.Jan 7 2019, 3:31 PM
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptJan 7 2019, 3:31 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani requested review of this revision.Jan 7 2019, 3:32 PM
ATIFAND accepted this revision.Jan 11 2019, 1:08 AM
This revision is now accepted and ready to land.Jan 11 2019, 1:08 AM
This revision was automatically updated to reflect the committed changes.