Add user.transactions conduit method
AbandonedPublic
Actions

Authored by mmodell on Feb 25 2019, 1:46 PM.

Details

Maniphest Tasks

Restricted Task

Reviewers

Aklapper

Patch without arc

git checkout -b D1144 && curl -L https://phabricator.wikimedia.org/D1144?download=true | git apply

Summary

Provides a user.transactions conduit API method which can be called by admins to get a list of transactions which were created by a specified user.

The results are grouped by object and include comments as well as any embedded metadata which is stored with the transactions.

Test Plan

called user.transactions with conduit console and got sensible results.

Diff Detail

Repository

rPHEX phabricator-extensions

Branch

wmf/stable

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 3217
Build 5373: differential-jessie	Jenkins
Build 5372: arc lint + arc unit

Event Timeline

mmodell created this revision.Feb 25 2019, 1:46 PM

Harbormaster completed remote builds in B3212: Diff 2974.Feb 25 2019, 1:46 PM

mmodell requested review of this revision.Feb 25 2019, 1:46 PM

mmodell added a task: Restricted Task.Feb 25 2019, 1:47 PM

This is what I previously wrote to get the job done, however, @Aklapper requested and epriestley wrote a much better implementation upstream at https://secure.phabricator.com/D20208

Turns out that the upstream method (transaction.search) doesn't work as expected. It only operates on a single object at a time (e.g. one task) so it doesn't give us a way to search for all transactions by a given user.