Page MenuHomePhabricator

Add user.transactions conduit method
AbandonedPublic

Authored by mmodell on Feb 25 2019, 1:46 PM.

Details

Maniphest Tasks
Restricted Task
Reviewers
Aklapper
Patch without arc
git checkout -b D1144 && curl -L https://phabricator.wikimedia.org/D1144?download=true | git apply
Summary

Provides a user.transactions conduit API method which can be called by admins to get a list of transactions which were created by a specified user.

The results are grouped by object and include comments as well as any embedded metadata which is stored with the transactions.

Test Plan

called user.transactions with conduit console and got sensible results.

Diff Detail

Repository
rPHEX phabricator-extensions
Branch
wmf/stable
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3212
Build 5367: differential-jessieJenkins
Build 5366: arc lint + arc unit

Event Timeline

mmodell created this revision.Feb 25 2019, 1:46 PM
mmodell requested review of this revision.Feb 25 2019, 1:46 PM
mmodell added a task: Restricted Task.Feb 25 2019, 1:47 PM
mmodell abandoned this revision.Feb 25 2019, 1:51 PM

This is what I previously wrote to get the job done, however, @Aklapper requested and epriestley wrote a much better implementation upstream at https://secure.phabricator.com/D20208

mmodell reclaimed this revision.Mar 6 2019, 7:46 PM

Turns out that the upstream method (transaction.search) doesn't work as expected. It only operates on a single object at a time (e.g. one task) so it doesn't give us a way to search for all transactions by a given user.

mmodell updated this revision to Diff 2975.Mar 6 2019, 8:02 PM

Only allow admins to call the method

mmodell edited the test plan for this revision. (Show Details)Mar 6 2019, 8:06 PM
mmodell updated the revert plan for this revision. (Show Details)
mmodell edited the summary of this revision. (Show Details)Mar 6 2019, 8:09 PM
mmodell abandoned this revision.Apr 18 2019, 11:28 PM