Page MenuHomePhabricator

app: list new `gerritadmin` LDAP group
ClosedPublic

Authored by MarcoAurelio on Mar 30 2019, 1:04 PM.

Details

Reviewers
EddieGP
Legoktm
bd808
Patch without arc
git checkout -b D1146 && curl -L https://phabricator.wikimedia.org/D1146?download=true | git apply
Summary

A new LDAP group exists called gerritadmin which does not yet appear at https://tools.wmflabs.org/ldap. Let's list it.

Revert Plan

git revert and deploy the revert.

Diff Detail

Repository
rTLDAP tool-ldap
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

MarcoAurelio requested review of this revision.Mar 30 2019, 1:04 PM
MarcoAurelio created this revision.

@Legoktm Could you please take a look at this one? Thank you.

I don't have arcanist set up anymore, can you email me or pastebin this as a .patch file? git format-patch HEAD~1 should do it. IIRC the suggested "Patch without arc" doesn't retain authorship information.

Legoktm accepted this revision.Apr 1 2019, 9:34 PM

Pushed and deployed.

This revision is now accepted and ready to land.Apr 1 2019, 9:34 PM
Legoktm closed this revision.Apr 1 2019, 9:34 PM