Remove unused file CustomLoginHandler
AcceptedPublic
Actions

Authored by Mainframe98 on Jul 19 2019, 4:59 PM.

Details

Maniphest Tasks

T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions
T223926: Phabricator login page does not show Welcome text / "Click button below" text anymore

Reviewers

mmodell
Paladox

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Patch without arc

git checkout -b D1151 && curl -L https://phabricator.wikimedia.org/D1151?download=true | git apply

Summary

This functionality has been superseded by configuration under Auth → Customize Messages → Login Screen Instructions.

Bug: T223926
Bug: T228518

Diff Detail

Repository

rPHEX phabricator-extensions

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 3230
Build 5391: differential-jessie

Event Timeline

Mainframe98 created this revision.Jul 19 2019, 4:59 PM

Restricted Application added a reviewer: Restricted Owners Package.Jul 19 2019, 4:59 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2019, 4:59 PM

Harbormaster failed remote builds in B3230: Diff 2988!

Mainframe98 added tasks: T223926: Phabricator login page does not show Welcome text / "Click button below" text anymore, T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.Jul 19 2019, 5:00 PM

Mainframe98 mentioned this in T228518: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions.

Mainframe98 updated this revision to Diff 2989.Jul 19 2019, 5:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2019, 5:04 PM

Harbormaster failed remote builds in B3231: Diff 2989!

Mainframe98 requested review of this revision.Jul 19 2019, 5:16 PM

Aklapper added a subscriber: Aklapper.Jul 19 2019, 7:09 PM

Paladox accepted this revision.Jul 19 2019, 7:33 PM

This revision is now accepted and ready to land.Jul 19 2019, 7:33 PM

Revision Contents
Changeset List

			Path	Packages
D	M		src/other/CustomLoginHandler.php (13 lines)

Diff 2988

View Options

src/other/CustomLoginHandler.php

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	2988		Jul 19 2019, 4:55 PM	★	★
Diff 2	2989		Jul 19 2019, 5:04 PM	★	★

Remove unused file CustomLoginHandlerAcceptedPublicActions