Page MenuHomePhabricator

Update projects names after renames
ClosedPublic

Authored by MarcoAurelio on Jan 6 2020, 10:28 PM.

Details

Reviewers
mmodell
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rPHEX6fc80547dcc6: Update projects names after renames
Patch without arc
git checkout -b D1157 && curl -L https://phabricator.wikimedia.org/D1157?download=true | git apply
Summary

#acl*operations-team was renamed to #acl*sre-team so we should rename it here as well. In addition, Ops-Access-Reviews is archived and indicates only Operations should be used; as such I'm renaming it here as well, even though I am not sure the process of creating a private subtask for each SRE-Access-Requests or LDAP-Access-Requests is still being done.

Diff Detail

Repository
rPHEX phabricator-extensions
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Restricted Application added a reviewer: Restricted Owners Package.Jan 6 2020, 10:28 PM
MarcoAurelio requested review of this revision.Jan 6 2020, 10:28 PM
MarcoAurelio planned changes to this revision.EditedJan 6 2020, 10:37 PM

There are further instances that I missed in Patch Set 1. I'll try to amend this Diff, but it is not intuitive for me how to do this via Arcanist.

src/policy/WMFSecurityPolicy.php
209

Needs to be renamed as well.

211

Ops-Access-Reviews is archived and in its description says only Operations should be added from now on. Are we creating private subtasks for SRE-Access-Requests / LDAP-Access-Requests stills though? I don't think we currently do?

MarcoAurelio edited the summary of this revision. (Show Details)

I was not able to amend via Arcanist so I uploaded a Git patch via the UI.

MarcoAurelio retitled this revision from Update project name after rename to Update projects names after renames.Jan 6 2020, 10:54 PM
mmodell added inline comments.Jan 7 2020, 9:50 AM
src/policy/WMFSecurityPolicy.php
211

I don't think createPrivateSubtask is even used anymore.

mmodell accepted this revision.Jan 7 2020, 9:50 AM
This revision is now accepted and ready to land.Jan 7 2020, 9:50 AM
This revision was automatically updated to reflect the committed changes.
src/policy/WMFSecurityPolicy.php
211

I think so too. I barely remember this happened when you selected, in a dropdown in the task, access request or similar. I don't think we use this anymore either.