Page MenuHomePhabricator

Make 'protect as security issue' add #security-team; refs. T242018
AbandonedPublic

Authored by MarcoAurelio on Jan 7 2020, 8:35 PM.

Details

Maniphest Tasks
T242018: Make ‘Protect as security issue’ add project #security-team
Reviewers
mmodell
sbassett
Reedy
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Patch without arc
git checkout -b D1158 && curl -L https://phabricator.wikimedia.org/D1158?download=true | git apply
Summary

The Security-Team requested at T242018: Make ‘Protect as security issue’ add project #security-team that the Protect as security issue custom Wikimedia Phabricator task "protector" adds to protected tasks not only Security but also Security-Team

Test Plan
  • Verify code correctness.
  • Deploy and see if things break?
Revert Plan

Revert the patch and deploy the revert.

Diff Detail

Repository
rPHEX phabricator-extensions
Branch
T242018 (branched from wmf/stable)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 3258
Build 5419: arc lint + arc unit

Event Timeline

Restricted Application added a reviewer: Restricted Owners Package.Jan 7 2020, 8:35 PM
MarcoAurelio requested review of this revision.Jan 7 2020, 8:35 PM
MarcoAurelio edited the summary of this revision. (Show Details)Jan 7 2020, 8:40 PM
MarcoAurelio edited the test plan for this revision. (Show Details)
MarcoAurelio updated the revert plan for this revision. (Show Details)
MarcoAurelio added subscribers: sbassett, Reedy.
This revision now requires changes to proceed.Jan 7 2020, 8:45 PM
MarcoAurelio abandoned this revision.Jan 7 2020, 8:52 PM

I'm suddenly not sure how to go forward with this, and I'm not sure how to update a Differential patch via Arcanist either. It looks $project = WMFSecurityPolicy::getProjectByName would add just once? I'll let @mmodell take a look.

I've got a patch for this ready.