Fixes T125167
Details
Details
- Maniphest Tasks
- T125167: ImageMagick engine
- Reviewers
ori fgiunchedi - Commits
- rTHMBREXT77ff68354aae: ImageMagick Engine
- Patch without arc
- git checkout -b D117 && curl -L https://phabricator.wikimedia.org/D117?download=true | git apply
Diff Detail
Diff Detail
- Repository
- rTHMBREXT Thumbor Plugins
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| wikimedia_thumbor/engine/imagemagick/imagemagick.py | ||
|---|---|---|
| 57 | I'd explain in a comment why the monkey patching is needed here | |
| 62 | return extension in ('.jpg', '.png') | |
| 71 | shouldn't both width/height be > 0 ? | |
| 168 | early return here possible since all branches return anyway? if not hasattr(self, 'buffer'): return self.image.size ... | |
Comment Actions
Improve style
| wikimedia_thumbor/engine/imagemagick/imagemagick.py | ||
|---|---|---|
| 71 | You can resize by width or height alone, in fact in what we do it's just width. So either requests parameter being set means that some resizing is going to happen. | |