Page MenuHomePhabricator

Fix main page of tools.wmflabs.org to work correctly on mobile devices.
ClosedPublic

Authored by Zoranzoki21 on Tue, Feb 4, 7:16 PM.

Details

Maniphest Tasks
T194943: Make Toolforge main page mobile-friendly
Reviewers
bd808
Commits
R1922:c153dafece0c: Fix main page of tools.wmflabs.org to work correctly on mobile devices.
Patch without arc
git checkout -b D1176 && curl -L https://phabricator.wikimedia.org/D1176?download=true | git apply
Summary

Fix main page of tools.wmflabs.org to work correctly on mobile devices.

Bug: T194943

Diff Detail

Repository
R1922 tool-admin-web
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Zoranzoki21 requested review of this revision.Tue, Feb 4, 7:16 PM
Zoranzoki21 created this revision.
Zoranzoki21 added a reviewer: bd808.

This system of CR is a bit confusable :)

Zoranzoki21 edited the summary of this revision. (Show Details)Tue, Feb 4, 7:18 PM

@bd808 Do you have free time to check this please?

bd808 added a comment.Thu, Feb 6, 11:48 PM

@bd808 Do you have free time to check this please?

It is "on my list"! Travel and a head cold are slowing me down a bit, but I will catch up soon. :)

bd808 requested changes to this revision.Sat, Feb 8, 12:35 AM

This makes the text horizontally scrollable in the card div which is in some sense an improvement, but I think the fix we really want is to make the image stack above the text on narrow viewports. Adding flex-wrap: wrap; to .media seems to do that (h/t https://stackoverflow.com/a/33093062/8171).

This revision now requires changes to proceed.Sat, Feb 8, 12:35 AM
Zoranzoki21 updated this revision to Diff 3038.Sat, Feb 8, 8:27 AM

@bd808 Yes, right. Looks much better, thank you! I made changes which you requested.

bd808 accepted this revision.Mon, Feb 10, 5:41 PM
This revision is now accepted and ready to land.Mon, Feb 10, 5:41 PM