Page MenuHomePhabricator

Support NRPE checks
ClosedPublic

Authored by dduvall on Oct 7 2015, 11:25 PM.

Details

Maniphest Tasks
T114284: Implement nrpe config parser to easily hook into Puppet managed checks
Reviewers
thcipriani
mmodell
mobrovac
demon
Commits
rMWTS9da7653650bd: Support NRPE checks
rMSCA9da7653650bd: Support NRPE checks
Patch without arc
git checkout -b D12 && curl -L https://phabricator.wikimedia.org/D12?download=true | git apply
Summary

Implemented an nrpe checktype for reusing existing Icinga/NRPE checks
in deployments.

By default, checks are loaded and registered from all NRPE definitions
in /etc/nagios/nrpe.d and can be referenced in checks.yaml using
type: nrpe.

checks:
  service_endpoints:
    type: nrpe
    command: check_service_endpoints

Implementation based on P2124.

Depends on D11. Fixes T114284.

Test Plan

Run unit tests with tox.

Define a valid nrpe check in checks.yaml and execute deploy.

Diff Detail

Branch
T114284
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

dduvall retitled this revision from to Support NRPE checks.
dduvall updated this object.
dduvall edited the test plan for this revision. (Show Details)
dduvall added reviewers: mmodell, thcipriani, demon.
demon edited edge metadata.
This revision is now accepted and ready to land.Oct 9 2015, 3:10 PM
mobrovac edited edge metadata.