Page MenuHomePhabricator

Support automatic file attachment in most upload workflows
ClosedPublic

Authored by Dylsss on Jun 19 2022, 4:37 AM.
Referenced Files
Unknown Object (File)
Wed, Mar 15, 1:02 PM
Unknown Object (File)
Thu, Mar 9, 11:35 AM
Unknown Object (File)
Sat, Mar 4, 11:46 AM
Unknown Object (File)
Feb 15 2023, 3:04 PM
Unknown Object (File)
Feb 15 2023, 3:33 AM
Unknown Object (File)
Feb 10 2023, 3:35 PM
Unknown Object (File)
Jan 12 2023, 6:39 PM
Unknown Object (File)
Dec 21 2022, 4:34 AM
Subscribers

Details

Reviewers
brennen
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Patch without arc
git checkout -b D1203 && curl -L https://phabricator.wikimedia.org/D1203?download=true | git apply
Summary

Move attachment logic around so that automatic attachment is supported when you drag and drop files, when copy and pasting, or when using the edit form upload dialog.

Bug: T310833

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint Skipped
Unit
Tests Passed
Build Status
Buildable 3301
Build 5462: arc lint + arc unit

Event Timeline

Restricted Application added a reviewer: Restricted Owners Package.Jun 19 2022, 4:37 AM

map.php contains unrelated changes due to T310850

brennen added a subscriber: brennen.

Tested with copy-and-paste, drag-and-drop, and the upload button. Works as expected.

This revision is now accepted and ready to land.Jun 22 2022, 3:32 PM

Hand merged separately. I do not know how to Differential.