Page MenuHomePhabricator

Use absolute shebangs only when packaged
ClosedPublic

Authored by dduvall on Mar 8 2016, 10:27 PM.

Details

Reviewers
thcipriani
Group Reviewers
Release-Engineering-Team
Commits
rMSCA6f7d0e7d2c3c: Use absolute shebangs only when packaged
Patch without arc
git checkout -b D143 && curl -L https://phabricator.wikimedia.org/D143?download=true | git apply
Summary

Reimplemented the absolute shebangs in bin scripts to be applied during
Debian packaging only. In most cases, development and virtualenv, an
absolute path causes problems.

This is not exactly a revert of acf7270536d79b56a020ddd2ef7b9679f50f59b3
as there were other important changes made there such as explicit use of
python2.

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dduvall updated this revision to Diff 411.Mar 8 2016, 10:27 PM
dduvall retitled this revision from to Use absolute shebangs only when packaged.
dduvall updated this object.
dduvall edited the test plan for this revision. (Show Details)
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMar 8 2016, 10:27 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

W: scap source: stronger-dependency-implies-weaker scap depends -> suggests php5-cli
N:
N: In the debian/control stanza for the given package, a stronger
N: dependency field implies one of the dependencies in a weaker dependency
N: field. In other words, the Depends field of the package requires that
N: one of the packages listed in Recommends or Suggests be installed, or a
N: package is listed in Recommends as well as Suggests.
N:
N: Current versions of dpkg-gencontrol will silently fix this problem by
N: removing the weaker dependency, but it may indicate a more subtle bug
N: (misspelling or forgetting to remove the stronger dependency when it was
N: moved to the weaker field).
N:
N: Refer to Debian Policy Manual section 7.2 (Binary Dependencies -
N: Depends, Recommends, Suggests, Enhances, Pre-Depends) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: control-file, Type: source
N:
W: scap source: binary-nmu-
https://integration.wikimedia.org/ci/job/beta-build-deb/17/ for more details.

thcipriani accepted this revision.Mar 8 2016, 11:26 PM
thcipriani added a reviewer: thcipriani.
thcipriani added a subscriber: thcipriani.

Looks dope. Should fix the docs not generating, too.

This revision is now accepted and ready to land.Mar 8 2016, 11:26 PM
This revision was automatically updated to reflect the committed changes.