Page MenuHomePhabricator

packaging: Remove 'suggests: php5-cli'
AbandonedPublic

Authored by mmodell on Mar 16 2016, 7:28 PM.

Details

Reviewers
thcipriani
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D151 && curl -L https://phabricator.wikimedia.org/D151?download=true | git apply
Summary

Fixes the lintian warning: php5-cli is already in 'depends'

Test Plan

submit this diff, see if jenkins complains

Diff Detail

Event Timeline

mmodell updated this revision to Diff 436.Mar 16 2016, 7:28 PM
mmodell retitled this revision from to packaging: Remove 'suggests: php5-cli'.
mmodell updated this object.
mmodell edited the test plan for this revision. (Show Details)
mmodell added a reviewer: thcipriani.
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptMar 16 2016, 7:28 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

W: scap source: binary-nmu-debian-revision-in-source 3.0.3-1+0~20160316192840.31~1.gbp185828
N:
N: The version number of your source package ends in +b and a number or has
N: a Debian revision containing three parts. These version numbers are used
N: by binary NMUs and should not be used as the source version. (The +b
N: form is the current standard; the three-part version number now
N: obsolete.)
N:
N: Refer to Debian Developer's Reference section 5.10.2.1 (Recompilation or
N: binary-only NMU) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: fields, Type: binary, udeb, source
N:
W: scap source: newer-standards-version 3.9.6 (current is 3.9.5)
N:
N: The source package refers to a Standards-Version which is newer than the
N: highest one lintian is programmed to check. If the source package is
N: correct, then please upgrade lintian to the newest version. (If there is
N: no newer lintian version, then please bug li
https://integration.wikimedia.org/ci/job/beta-build-deb/31/ for more details.

demon added a subscriber: demon.Mar 16 2016, 7:44 PM

Once D133: Rewrite refreshCdbJsonFiles in python lands, shouldn't we keep it in suggests (for scap2 linting) as opposed to required?

In D151#3507, @demon wrote:

Once D133: Rewrite refreshCdbJsonFiles in python lands, shouldn't we keep it in suggests (for scap2 linting) as opposed to required?

That's probably right. @thcipriani: do you wanna remove php5-cli from the Depends section in D133 and I'll just abandon this one?

Now if I could just figure out how to silence the other warnings...

mmodell abandoned this revision.Mar 16 2016, 8:31 PM
thcipriani edited edge metadata.Mar 17 2016, 5:49 PM
In D151#3511, @mmodell wrote:
In D151#3507, @demon wrote:

Once D133: Rewrite refreshCdbJsonFiles in python lands, shouldn't we keep it in suggests (for scap2 linting) as opposed to required?

That's probably right. @thcipriani: do you wanna remove php5-cli from the Depends section in D133

Done.