Page MenuHomePhabricator

Fix lintian warnings
ClosedPublic

Authored by mmodell on Apr 7 2016, 9:35 PM.

Details

Reviewers
thcipriani
hashar
Group Reviewers
Release-Engineering-Team
Commits
rMSCA567dde91d565: Fix lintian warnings
Patch without arc
git checkout -b D198 && curl -L https://phabricator.wikimedia.org/D198?download=true | git apply
Summary

fix 'python-script-but-no-python-dep' warning from lintian
override some other useless warnings.

Test Plan

submit this diff, see if lintian bitches

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mmodell updated this revision to Diff 551.Apr 7 2016, 9:35 PM
mmodell retitled this revision from to Add dependency on python2.7 (fixes lintian warning).
mmodell updated this object.
mmodell edited the test plan for this revision. (Show Details)
mmodell added reviewers: thcipriani, hashar.
Restricted Application added a reviewer: Release-Engineering-Team. · View Herald TranscriptApr 7 2016, 9:35 PM
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript

Build is unstable

W: scap source: binary-nmu-debian-revision-in-source 3.1.0-1+0~20160407213509.61~1.gbp08b157
N:
N: The version number of your source package ends in +b and a number or has
N: a Debian revision containing three parts. These version numbers are used
N: by binary NMUs and should not be used as the source version. (The +b
N: form is the current standard; the three-part version number now
N: obsolete.)
N:
N: Refer to Debian Developer's Reference section 5.10.2.1 (Recompilation or
N: binary-only NMU) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: fields, Type: binary, udeb, source
N:
W: scap source: newer-standards-version 3.9.6 (current is 3.9.5)
N:
N: The source package refers to a Standards-Version which is newer than the
N: highest one lintian is programmed to check. If the source package is
N: correct, then please upgrade lintian to the newest version. (If there is
N: no newer lintian version, then please bug li

Link to build: https://integration.wikimedia.org/ci/job/beta-build-deb/61/
See console output for more information: https://integration.wikimedia.org/ci/job/beta-build-deb/61/console

mmodell updated this revision to Diff 552.Apr 7 2016, 9:54 PM
mmodell edited edge metadata.

actually fix lintian error this time

W: scap source: binary-nmu-debian-revision-in-source 3.1.0-1+0~20160407215439.62~1.gbpe0e5c2
N:
N: The version number of your source package ends in +b and a number or has
N: a Debian revision containing three parts. These version numbers are used
N: by binary NMUs and should not be used as the source version. (The +b
N: form is the current standard; the three-part version number now
N: obsolete.)
N:
N: Refer to Debian Developer's Reference section 5.10.2.1 (Recompilation or
N: binary-only NMU) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: fields, Type: binary, udeb, source
N:
W: scap source: newer-standards-version 3.9.6 (current is 3.9.5)
N:
N: The source package refers to a Standards-Version which is newer than the
N: highest one lintian is programmed to check. If the source package is
N: correct, then please upgrade lintian to the newest version. (If there is
N: no newer lintian version, then please bug li
https://integration.wikimedia.org/ci/job/beta-build-deb/62/ for more details.

mmodell updated this revision to Diff 553.Apr 7 2016, 10:02 PM

add overrides to silence more warnings

N: 2 tags overridden (2 warnings)

https://integration.wikimedia.org/ci/job/beta-build-deb/63/ for more details.

mmodell retitled this revision from Add dependency on python2.7 (fixes lintian warning) to Fix lintian warnings.Apr 7 2016, 10:04 PM
mmodell updated this object.
thcipriani accepted this revision.Apr 7 2016, 10:16 PM
thcipriani edited edge metadata.
(ノ^ヮ^)ノ*:・゚✧ dpkg --fsys-tarfile scap_3.1.0-1+0~20160407220234.63~1.gbp381924_all.deb | tar -xOf - ./usr/bin/refreshCdbJsonFiles | head -1
#! /usr/bin/python

Sweet! Does this mean we can get rid of the change-shebangs.patch patch all together now (or always)? I guess we're also relying on python2 being the primary system python...

This revision is now accepted and ready to land.Apr 7 2016, 10:16 PM
(ノ^ヮ^)ノ*:・゚✧ dpkg --fsys-tarfile scap_3.1.0-1+0~20160407220234.63~1.gbp381924_all.deb | tar -xOf - ./usr/bin/refreshCdbJsonFiles | head -1
#! /usr/bin/python

Sweet! Does this mean we can get rid of the change-shebangs.patch patch all together now (or always)? I guess we're also relying on python2 being the primary system python...

Apparently dh_python2 takes care of it for us, so yes. We aren't relying on python2 being the primary system python, afaik, but we are relying on python2 being installed (hence the dependency on python2.7 package)

This revision was automatically updated to reflect the committed changes.