Page MenuHomePhabricator

ldapnames must match at least one phid to query users data.
ClosedPublic

Authored by mmodell on May 11 2016, 12:23 AM.

Details

Maniphest Tasks
T134959: LTC needed for user.ldapquery conduit api
Reviewers
bd808
Commits
rPHEXe81944a45edb: ldapnames must match at least one phid to query users data.
Patch without arc
git checkout -b D230 && curl -L https://phabricator.wikimedia.org/D230?download=true | git apply
Summary

Addresses two bugs:

  • When none of the supplied ldapnames match a user phid, don't return any results. throw ERR-INVALID-PARAMETER instead.
  • When there are matches, include the corresponding ldap usernames in the response records.
Test Plan
  • go to 'user.ldapquery' on conduit console.
  • Input random invalid usernames,
    • result should be an error rather than 100 random users (because of unbounded query)
  • Input valid usernames
    • result should include the input ldap username among the response user_info records.

Diff Detail

Repository
rPHEX phabricator-extensions
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mmodell retitled this revision from to ldapnames must match at least one phid to query users data..
mmodell updated this object.
mmodell edited the test plan for this revision. (Show Details)
mmodell added a reviewer: bd808.

Return the ldap usernames in the user_info dictionary responses

mmodell edited the test plan for this revision. (Show Details)
bd808 edited edge metadata.

Logic looks right. I still don't have a local phab instance setup to test these things with.

This revision is now accepted and ready to land.May 11 2016, 12:34 AM
This revision was automatically updated to reflect the committed changes.