Page MenuHomePhabricator

pep8 fixes
ClosedPublic

Authored by demon on Oct 26 2015, 10:45 PM.

Details

Reviewers
dduvall
Commits
rMWTS62a250a29b2d: pep8 fixes
rMWTS60a5dc675b8a: pep8 fixes
rMSCA62a250a29b2d: pep8 fixes
rMSCA60a5dc675b8a: pep8 fixes
Patch without arc
git checkout -b D26 && curl -L https://phabricator.wikimedia.org/D26?download=true | git apply
Summary

Mostly removing lambdas in favor of actual defs

Test Plan

Ran all tests, plus deployment, all good

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

demon updated this revision to Diff 86.Oct 26 2015, 10:45 PM
demon retitled this revision from to pep8 fixes.
demon updated this object.
demon edited the test plan for this revision. (Show Details)
demon added a reviewer: dduvall.
dduvall accepted this revision.Oct 27 2015, 12:20 AM
dduvall edited edge metadata.

I suppose you could replace lambdas with locally scoped def's to minimize the footprint of this change, but it looks good to me regardless.

This revision is now accepted and ready to land.Oct 27 2015, 12:20 AM
This revision was automatically updated to reflect the committed changes.