Page MenuHomePhabricator

handle ?diff=1 on /r/revision/ url redirection
ClosedPublic

Authored by mmodell on Jun 13 2016, 9:08 PM.

Details

Maniphest Tasks
T137224: Redirect Gitblit urls (git.wikimedia.org) -> Diffusion urls (phabricator.wikimedia.org/diffusion)
Reviewers
Paladox
Danny_B
Commits
rPHEX42bda8f0e063: handle ?diff=1 on /r/revision/ url redirection
Patch without arc
git checkout -b D265 && curl -L https://phabricator.wikimedia.org/D265?download=true | git apply
Summary

This is needed so we can redirect gitblit /patch/* urls to
diffusion. (see T137224#2376481)

refs T137224

These are all valid now:

  • /r/revision/$project;$hash?diff=1
  • /r/commit/$project;$hash
  • /r/commit/$project;$hash?patch
  • /r/patch/$project;$hash
Test Plan

doing it live

Diff Detail

Event Timeline

mmodell updated this revision to Diff 720.Jun 13 2016, 9:08 PM
mmodell retitled this revision from to handle ?diff=1 on /r/revision/ url redirection.
mmodell updated this object.
mmodell edited the test plan for this revision. (Show Details)
mmodell added a reviewer: Danny_B.
Paladox accepted this revision.Jun 13 2016, 9:13 PM
Paladox added a reviewer: Paladox.
Paladox added a subscriber: Paladox.

Haven't tested but looks good.

This revision is now accepted and ready to land.Jun 13 2016, 9:13 PM
mmodell updated this revision to Diff 722.Jun 14 2016, 12:38 AM
mmodell edited edge metadata.

support /r/patch/$project;$hash and /r/revision/$project;$hash?patch

mmodell updated this revision to Diff 723.Jun 14 2016, 12:42 AM

These are all valid now:

  • /r/revision/$project;hash?diff=1
  • /r/patch/$project;$hash
  • /r/commit/$project;$hash
  • /r/commit/$project;$hash?patch
mmodell updated this object.Jun 14 2016, 12:44 AM
mmodell closed this revision.Jun 14 2016, 12:53 AM