Page MenuHomePhabricator

Update submodules from cache
AbandonedPublic

Authored by thcipriani on Jun 27 2016, 10:03 PM.
Referenced Files
Unknown Object (File)
Fri, Nov 10, 9:11 PM
Unknown Object (File)
Tue, Nov 7, 11:20 PM
Unknown Object (File)
Nov 5 2023, 9:05 PM
Unknown Object (File)
Nov 3 2023, 8:56 PM
Unknown Object (File)
Nov 1 2023, 4:05 AM
Unknown Object (File)
Oct 29 2023, 4:22 PM
Unknown Object (File)
Oct 28 2023, 4:26 AM
Unknown Object (File)
Oct 27 2023, 3:21 AM

Details

Maniphest Tasks
T137124: Scap3 submodule space issues
Reviewers
mmodell
demon
hashar
Group Reviewers
Release-Engineering-Team
Patch without arc
git checkout -b D284 && curl -L https://phabricator.wikimedia.org/D284?download=true | git apply
Summary

Since local git clones use hardlinks for objects, space isn't much of a
consideration for additional local clones. Space *is* a consideration
for submodules since we have been registering submodules for individual
revdirs; pointing .gitmodules to the git_server rather than the cache
dir.

This patch initializes and registers submodules in the cache directory
and remaps each rev to use objects from the cache dir (which is local,
so it creates hardlinks). Potentially saves disk-space for deploys were
submodules represent the majority of code/objects.

Fixes T137124

Diff Detail

Repository
rMSCA Scap
Branch
submodulpocalypse
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

thcipriani retitled this revision from to Update submodules from cache.
thcipriani updated this object.
thcipriani edited the test plan for this revision. (Show Details)
thcipriani added reviewers: mmodell, demon, hashar.

LGTM. I can't test it though. It would be great to see how it works in beta cluster.

mmodell edited edge metadata.
This revision is now accepted and ready to land.Jun 29 2016, 7:16 PM

Still not sure this is the right way to do this. Seems like this might be prone to breakage.