Page MenuHomePhabricator

Support skipping remaining continue prompts
ClosedPublic

Authored by dduvall on Aug 25 2016, 8:53 PM.

Details

Reviewers
thcipriani
mmodell
mobrovac
demon
Group Reviewers
Release-Engineering-Team
Commits
rMSCA92f46d5a43d2: Support skipping remaining continue prompts
Patch without arc
git checkout -b D323 && curl -L https://phabricator.wikimedia.org/D323?download=true | git apply
Summary

Follows up on T142990 to allow the user to continue through all
remaining deployment groups. This feature is necessary as there may be
many prompts if the repo is configured with a relatively small
group_size.

Test Plan

Deploy using a number of server groups and ensure that all given
choices work as expected.

Diff Detail

Repository
rMSCA Scap
Branch
yes-to-all-T142990
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 786
Build 1162: differential-jessieJenkins
Build 1161: arc lint + arc unit

Event Timeline

dduvall retitled this revision from to Support skipping remaining continue prompts.
dduvall updated this object.
dduvall edited the test plan for this revision. (Show Details)
dduvall added reviewers: demon, mobrovac, mmodell, thcipriani.
dduvall edited edge metadata.

Fixed continue all conditional

mmodell edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2016, 9:50 PM
thcipriani edited edge metadata.

This does make a really nice interface.

This makes me think we could give folks other options here. Like maybe there should be a cancel and rollback option?

Continue? ([d]etailed/[C]oncise report,[y]es,[n]o,[r]ollback and cancel)

I'm only trolling a little here—modification at runtime does seem to make a nice interface as long as there's a way to override it via command flags.

This revision was automatically updated to reflect the committed changes.