Page MenuHomePhabricator

Convert ParsoidClient to RESTBase api
ClosedPublic

Authored by bd808 on Aug 30 2016, 9:34 PM.

Details

Maniphest Tasks
T114186: Fix ParsoidClient to talk to RESTBase instead of Parsoid
Reviewers
Niharika
Commits
rWIEG26e3cd18e5b7: Convert ParsoidClient to RESTBase api
Patch without arc
git checkout -b D330 && curl -L https://phabricator.wikimedia.org/D330?download=true | git apply
Summary

Call the RESTBase wikitext-to-html endpoint rather than directly
interacting with Parsoid.

Bug: T114186

Test Plan
  • Apply patch
  • Clear out any /var/cache/iegreview content in your test VM
  • Make sure that you aren't setting PARSOID_URL in a local .env file
  • View a campaign proposal
  • See nicely rendered HTML rather than an error message from Parsoid/Varnish

Diff Detail

Repository
rWIEG wikimedia-iegreview
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bd808 retitled this revision from to Convert ParsoidClient to RESTBase api.
bd808 updated this object.
bd808 edited the test plan for this revision. (Show Details)
bd808 added a reviewer: Niharika.

Change references to Parsoid to mention RESTBase instead.

Niharika edited edge metadata.

Awesome. Works for me locally.

This revision is now accepted and ready to land.Aug 31 2016, 8:59 AM
This revision was automatically updated to reflect the committed changes.