Page MenuHomePhabricator

Add support for elasticsearch 2
ClosedPublic

Authored by Paladox on Sep 29 2016, 7:01 PM.

Details

Maniphest Tasks
T146843: Re-evaluate how we implement phabricator's search engine
Reviewers
mmodell
Commits
rPHABaf4367086d9a: Add support for elasticsearch 2
Patch without arc
git checkout -b D388 && curl -L https://phabricator.wikimedia.org/D388?download=true | git apply
Summary

Adds a new config that is used to tell which version elasticsearch you
use, for example if you use elasticsearch 1, then you put in there 1, and
if you use 2, then 2.

@EBernhardson helped alot with figuring how to get it to work with
elasticsearch 2 properly.

@mmodell helped with helpig me creat a config we could use.

Fixes T146843

Change-Id: Id275378a7d2827d2dca6c1b3c99d60aa767ee059

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint SkippedExcuse: Same as before
Unit
Unit Tests Skipped
Build Status
Buildable 1070
Build 1546: differential-jessieJenkins
Build 1545: arc lint + arc unit

Event Timeline

Paladox updated this revision to Diff 1045.Sep 29 2016, 7:01 PM
Paladox retitled this revision from to Fixes T146843 Add support for elasticsearch 2.
Paladox updated this object.
Paladox edited the test plan for this revision. (Show Details)
Paladox added subscribers: EBernhardson, mmodell.
Restricted Application added a reviewer: mmodell. · View Herald TranscriptSep 29 2016, 7:01 PM
Paladox updated this object.Sep 29 2016, 7:02 PM
Paladox edited edge metadata.
Paladox updated the revert plan for this revision. (Show Details)
Paladox updated this object.

@mmodell I wonder if we can set it so if we set value 2 or higher that will work?

Paladox updated this revision to Diff 1046.Sep 29 2016, 7:09 PM

Updating commit msg

Paladox retitled this revision from Fixes T146843 Add support for elasticsearch 2 to Add support for elasticsearch 2.Sep 29 2016, 7:10 PM
mmodell accepted this revision.Sep 29 2016, 7:20 PM
mmodell edited edge metadata.
This revision is now accepted and ready to land.Sep 29 2016, 7:20 PM
Paladox closed this revision.Sep 29 2016, 8:19 PM