Page MenuHomePhabricator

Supports any value higher then 2 for indexExists to work
ClosedPublic

Authored by Paladox on Sep 29 2016, 7:50 PM.

Details

Maniphest Tasks
T146843: Re-evaluate how we implement phabricator's search engine
Reviewers
Paladox
mmodell
Commits
rPHDEPa59c812e77e6: Updated git submodules
rPHAB5347029702ef: Supports any value higher then 2 for indexExists to work
Patch without arc
git checkout -b D389 && curl -L https://phabricator.wikimedia.org/D389?download=true | git apply
Summary

Since this dosen't seem to break in any other versions of elasticsearch,
there brining out 5, so let's also support 5.

@mmodell helped me with this.

Fixes T146843

Change-Id: I8a478d83256d8cb54c2b9a7a921fe6f4490657a9

Diff Detail

Repository
rPHAB Phabricator
Branch
wmf/stable
Lint
Lint SkippedExcuse: Same as before
Unit
Unit Tests Skipped
Build Status
Buildable 1072
Build 1550: differential-jessieJenkins
Build 1549: arc lint + arc unit

Event Timeline

Paladox updated this revision to Diff 1047.Sep 29 2016, 7:50 PM
Paladox retitled this revision from to Supports any value higher then 2 for indexExists to work.
Paladox updated this object.
Paladox edited the test plan for this revision. (Show Details)
Paladox added a subscriber: mmodell.
Restricted Application added a reviewer: mmodell. · View Herald TranscriptSep 29 2016, 7:50 PM
Paladox accepted this revision.Sep 29 2016, 7:51 PM
Paladox added a reviewer: Paladox.
This revision is now accepted and ready to land.Sep 29 2016, 7:51 PM
mmodell added inline comments.Sep 29 2016, 7:52 PM
src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php
288

if ((int)$this->version >= 2) {

Paladox updated this revision to Diff 1048.Sep 29 2016, 7:54 PM
Paladox edited edge metadata.

Minor changes

Paladox marked an inline comment as done.Sep 29 2016, 7:55 PM
Paladox closed this revision.Sep 29 2016, 8:19 PM