refs T142880
Details
Details
- Maniphest Tasks
- T147546: Write "how to build scap plugins" developer documentation
T142880: Create `scap swat` command to automate patch merging & testing during a swat deployment - Reviewers
thcipriani • mobrovac demon - Group Reviewers
Release-Engineering-Team - Commits
- rMSCAd407eaf640e1: Expand scap documentation, especially plugins and cli stuff
- Patch without arc
- git checkout -b D403 && curl -L https://phabricator.wikimedia.org/D403?download=true | git apply
tox -edoc
Diff Detail
Diff Detail
- Repository
- rMSCA Scap
- Branch
- plugin-docs (branched from master)
- Lint
Lint Warnings Severity Location Code Message Warning scap/plugins/__init__.py:133 PYFLAKES PYFLAKES Advice scap/plugins/__init__.py:36 E501 PEP8 E501 - Unit
Tests Passed - Build Status
Buildable 1098 Build 1599: build-beta-package.deb Jenkins Build 1598: differential-jessie Jenkins Build 1597: arc lint + arc unit
Event Timeline
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161005023333.137~1.gbpbe9198
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/137/ for more details.
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/179/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/179/console
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161005023551.138~1.gbpbe9198
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/138/ for more details.
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161005194301.142~1.gbp82d622
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/142/ for more details.
| scap/plugins/__init__.py | ||
|---|---|---|
| 118–136 | the only change here is added error handling: an exception while evaluating a plugin shouldn't cause the entire scap application to fail | |
Comment Actions
Do you mean unit testing or just how to run them? Currently there is no support for unit testing but we could perhaps come up with a standard test entry point and a 'scap test' sub-command that calls it?
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161005201553.143~1.gbp82d622
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/143/ for more details.
Comment Actions
I meant more in the debug/test-while-developing sense, but perhaps that would be better left for another patch (even though, this information should be considered essential if we want people to actually use the plugins capability).
+1 to the scap test idea!
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161005223811.144~1.gbp82d622
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/144/ for more details.
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161006001241.145~1.gbp82d622
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/145/ for more details.
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/beta-build-deb/146/
See console output for more information: https://integration.wikimedia.org/ci/job/beta-build-deb/146/console
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161006004228.147~1.gbp6e90f6
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/147/ for more details.
Comment Actions
W: scap source: changelog-should-mention-nmu
N:
N: When you NMU a package, that fact should be mentioned on the first line
N: in the changelog entry. Use the words "NMU" or "Non-maintainer upload"
N: (case insensitive).
N:
N: Maybe you didn't intend this upload to be a NMU, in that case, please
N: double-check that the most recent entry in the changelog is
N: byte-for-byte identical to the maintainer or one of the uploaders. If
N: this is a local package (not intended for Debian), you can suppress this
N: warning by putting "local" in the version number or "local package" on
N: the first line of the changelog entry.
N:
N: Refer to Debian Developer's Reference section 5.11.3 (Using the DELAYED/
N: queue) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: nmu, Type: source
N:
W: scap source: source-nmu-has-incorrect-version-number 3.3.0-1+0~20161007183745.151~1.gbp624959
N:
N: A source NMU should have a Debian
https://integration.wikimedia.org/ci/job/beta-build-deb/151/ for more details.