Paths

Table of Contentst

Make ProjectOpenTasksProfilePanel actually link to open tasks only
ClosedPublic
Actions

Authored by Aklapper on Oct 8 2016, 1:56 PM.

Details

Maniphest Tasks

T127903: Projects should have an "Open Tasks" view by default

Reviewers

Paladox
Zppix
mmodell
Luke081515

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rPHDEP8bd24a644e23: Updated git submodules
rPHEXc46eb5e027ba: Make ProjectOpenTasksProfilePanel actually link to open tasks only

Patch without arc

git checkout -b D408 && curl -L https://phabricator.wikimedia.org/D408?download=true | git apply

Summary

https://phabricator.wikimedia.org/T127903#2636381

Test Plan

I did not test this (sorry, travelling).
No idea whether I need to URL-escape the ampersand.

Diff Detail

Repository

rPHEX phabricator-extensions

Branch

wmf/stable

Lint

Lint OK

Unit

No Unit Test Coverage

Build Status

Buildable 1119
Build 1646: differential-jessie	Jenkins
Build 1645: arc lint + arc unit

Event Timeline

Aklapper updated this revision to Diff 1088.Oct 8 2016, 1:56 PM

Aklapper retitled this revision from to Make ProjectOpenTasksProfilePanel actually link to open tasks only.

Aklapper updated this object.

Aklapper edited the test plan for this revision. (Show Details)

Aklapper added a reviewer: mmodell.

Aklapper added a subscriber: Aklapper.

Restricted Application added a reviewer: Restricted Owners Package.Oct 8 2016, 1:56 PM

Restricted Application edited edge metadata. · View Herald TranscriptOct 8 2016, 1:56 PM

Paladox added a reviewer: Paladox.Oct 8 2016, 2:00 PM

I've deployed this on https://phab-01.wmflabs.org/ please test it?

Works as expected on phab-01. Thanks.

Your welcome.

This revision is now accepted and ready to land.Oct 8 2016, 4:18 PM

Luke081515 accepted this revision.Oct 8 2016, 4:19 PM

Luke081515 added a reviewer: Luke081515.

I presume you can land this.

arc patch D408 --nobranch

arc land wmf/stable

Looks good

Closed by commit rPHEXc46eb5e027ba: Make ProjectOpenTasksProfilePanel actually link to open tasks only (authored by Andre Klapper <a9016009@gmx.de>, committed by mmodell). · Explain WhyOct 9 2016, 3:24 PM

This revision was automatically updated to reflect the committed changes.

mmodell edited edge metadata.Oct 9 2016, 3:25 PM

This comment was removed by mmodell.

mmodell added a task: T127903: Projects should have an "Open Tasks" view by default.Oct 9 2016, 4:14 PM

Revision Contents
Changeset List

Path

Size

src/

panel/

ProjectOpenTasksProfilePanel.php

2 lines

Diff 1088

View Options

src/panel/ProjectOpenTasksProfilePanel.php

Make ProjectOpenTasksProfilePanel actually link to open tasks onlyClosedPublicActions