Innodb fulltext search doesn't support altering ft_boolean_syntax
to make queries default to AND instead of OR. This forces boolean
AND matching by prepending + to all words that don't already have
either prefix of '+' or '-'
Refs T146673
Details
Details
- Maniphest Tasks
- T146673: Contention on search phabricator database creating full phabricator outages
- Reviewers
Paladox jcrespo hashar - Commits
- rPHDEP53c6b5383216: Updated git submodules
- Patch without arc
- git checkout -b D413 && curl -L https://phabricator.wikimedia.org/D413?download=true | git apply
Ran several search queries on my test instance of
phabricator and in each case I got sensible results.
This patch is also deployed on http://phab-01.wmflabs.org, testing welcome.
Diff Detail
Diff Detail
- Repository
- rPHAB Phabricator
- Branch
- wmf/stable
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1141 Build 1679: differential-jessie Jenkins Build 1678: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/199/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/199/console
Comment Actions
Note: the build failure is because jenkins isn't set up to handle phabricator's unit test suite. The test suite passed in my dev environment.
Comment Actions
Thanks to @Paladox for switching phab-01 to innodb. I'm reindexing now so searches should actually be hitting the innodb search index now.
Comment Actions
This change is now cherry-picked on iridium and merged to wmf/stable for the next deploy.