Page MenuHomePhabricator

[BREAKING CHANGE] Refine variable naming
ClosedPublic

Authored by Volker_E on Nov 11 2016, 1:50 AM.

Details

Reviewers
Prtksxna
JGirault
Commits
rWMUI603dbc465d08: [BREAKING CHANGE] Refine variable naming
Patch without arc
git checkout -b D447 && curl -L https://phabricator.wikimedia.org/D447?download=true | git apply
Summary

Refining variable naming by making modifier variables for states
indicated by --.

Bug: T147612

Diff Detail

Repository
rWMUI WikimediaUI Base
Branch
refine-color-variable-naming-T147612
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 1237
Build 1858: arc lint + arc unit

Event Timeline

Volker_E updated this revision to Diff 1176.Nov 11 2016, 1:50 AM
Volker_E retitled this revision from to [BREAKING CHANGE] Refine variable naming.
Volker_E updated this object.
Volker_E edited the test plan for this revision. (Show Details)
Volker_E added reviewers: Prtksxna, JGirault.
JGirault accepted this revision.Nov 15 2016, 1:18 AM
JGirault edited edge metadata.

Looks good

This revision is now accepted and ready to land.Nov 15 2016, 1:18 AM
Closed by commit rWMUI603dbc465d08: [BREAKING CHANGE] Refine variable naming (authored by Volker E <volker.e@wikimedia.org>). · Explain WhyNov 15 2016, 1:31 AM
This revision was automatically updated to reflect the committed changes.