Page MenuHomePhabricator

[BREAKING CHANGE] Turn `*highlight` variable to appropriate property
ClosedPublic

Authored by Volker_E on Nov 15 2016, 3:05 AM.

Details

Reviewers
Prtksxna
JGirault
Commits
rWMUIb5ae31320ed1: [BREAKING CHANGE] Turn `*highlight` variable to appropriate property
Patch without arc
git checkout -b D450 && curl -L https://phabricator.wikimedia.org/D450?download=true | git apply
Summary

Changing *highlight variable to *background-color as it's the
correct descriptor. Also changing passive to active notation to
establish variables and "states" rule.

Bug: T147612

Diff Detail

Repository
rWMUI WikimediaUI Base
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Volker_E updated this revision to Diff 1189.Nov 15 2016, 3:05 AM
Volker_E retitled this revision from to [BREAKING CHANGE] Turn `*highlight` variable to appropriate property.
Volker_E updated this object.
Volker_E edited the test plan for this revision. (Show Details)
Volker_E added reviewers: Prtksxna, JGirault.
JGirault accepted this revision.Nov 15 2016, 11:06 PM
JGirault edited edge metadata.

Looks good

This revision is now accepted and ready to land.Nov 15 2016, 11:06 PM
This revision was automatically updated to reflect the committed changes.