Initialized debian files using stdeb, with some cleanup according to
https://wikitech.wikimedia.org/wiki/Git-buildpackage
Details
Details
- Maniphest Tasks
- Restricted Task
T118015: Debian Packaging for scap - Reviewers
Joe faidon bd808 fgiunchedi - Group Reviewers
Release-Engineering-Team - Commits
- rMSCA73154370d176: Initial Debian packaging
- Patch without arc
- git checkout -b D46 && curl -L https://phabricator.wikimedia.org/D46?download=true | git apply
Create a tag named upstream/3.0 and build package with git-buildpackage --git-ignore-branch --git-export-dir=/tmp/build/scap -us -uc
Diff Detail
Diff Detail
- Repository
- rMSCA Scap
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
I'm sure I screwed something up here.
| debian/control | ||
|---|---|---|
| 12 | I based these dependency versions off what's available in Precise, assuming we'd need to backport it. | |
Comment Actions
Should be rebased since D45: Include a setup.py to help with packaging landed, don't need the setup.(py|cfg) change here anymore.
Comment Actions
builds fine locally, lintian warnings below. debian/copyright one we should fix, ditto for description and standards-version, all fairly easy
Now running lintian... W: scap source: changelog-should-mention-nmu W: scap source: source-nmu-has-incorrect-version-number 3.0-1 W: scap source: no-debian-copyright W: scap source: ancient-standards-version 3.9.3 (current is 3.9.6) W: python-scap: new-package-should-close-itp-bug E: python-scap: no-copyright-file E: python-scap: extended-description-is-empty W: python-scap: binary-without-manpage usr/bin/compile-wikiversions W: python-scap: binary-without-manpage usr/bin/deploy W: python-scap: binary-without-manpage usr/bin/deploy-local W: python-scap: binary-without-manpage usr/bin/deploy-log W: python-scap: binary-without-manpage usr/bin/hhvm-graceful-all W: python-scap: binary-without-manpage usr/bin/mw-update-l10n W: python-scap: binary-without-manpage usr/bin/mwversionsinuse W: python-scap: binary-without-manpage usr/bin/scap W: python-scap: binary-without-manpage usr/bin/scap-hhvm-restart W: python-scap: binary-without-manpage usr/bin/scap-purge-l10n-cache W: python-scap: binary-without-manpage usr/bin/scap-rebuild-cdbs W: python-scap: binary-without-manpage usr/bin/sync-common W: python-scap: binary-without-manpage usr/bin/sync-dir W: python-scap: binary-without-manpage usr/bin/sync-docroot W: python-scap: binary-without-manpage usr/bin/sync-file W: python-scap: binary-without-manpage usr/bin/sync-master W: python-scap: binary-without-manpage usr/bin/sync-wikiversions Finished running lintian.
| debian/changelog | ||
|---|---|---|
| 5 | Maintainer field in debian/control doesn't have "Team" so it should be consistent here | |
| debian/control | ||
| 8 | just "scap" I think would be easier to find/remember as a binary package | |
Comment Actions
Create a tag named upstream/3.0
I guess we need to pick an official tag point if we're going to declare 3.0 and push said tag :)
Comment Actions
Addressed all comments by @fgiunchedi and additionally added a patch to set a more suitable bin_dir config default for the packaged version.
Comment Actions
Indeed! Maybe we should pick a point after the scap3 docs are "finished" (i.e. drafted).
I tested the deb build, installed it, and ran deploy and deploy-log from their new homes in /usr/bin. It all went well.
| debian/control | ||
|---|---|---|
| 19 | Damn it feels good to be a gansta. Go team! | |