What about also allowing the link to look like

https://phabricator.wikimedia.org/r/mediawiki/extensions/

And

https://phabricator.wikimedia.org/mediawiki/extensions/

And so on

Looking at the diff I think this is for the url to look like gerrit. I think for viewing the repos should look like this too redirecting links

In D51#1252, @Paladox wrote:

What about also allowing the link to look like
https://phabricator.wikimedia.org/r/mediawiki/extensions/

Mukunda will have to answer for this one, I wouldn't mind using /r/ for repo paths, but I'll let him answer.

And
https://phabricator.wikimedia.org/mediawiki/extensions/
And so on

No, we don't want to overload the domain root to potentially conflict with future Phabricator applications.

Looking at the diff I think this is for the url to look like gerrit. I think for viewing the repos should look like this too redirecting links

No, the URLs aren't meant to look like Gerrit. They're meant to just exist as URLs with similar foo/bar/baz repo paths so we can redirect old Gitblit/Gerrit URLs to Phabricator properly. They're not meant to be used as links or accessed directly, really, so there's no requirement for them to be pretty or memorable.

Lgtm, can we test it out on iridium? Just wanna see it in action before accepting.

@demon I just set it up on phab-01: https://phab-01.wmflabs.org/r/phabricator/phabricator

(none of the other repos will redirect to a working repo, since the others aren't set up on phab-01, but they should all redirect to the correct callsign url)

In D51#1278, @demon wrote:

Per IRC, we need to make sure we support at least the URL patterns outlined in:

P2324 current [gitweb] config for gerrit

1	[gitweb]
2	url = https://git.wikimedia.org
3	type = custom
4	revision = /commit/${project}/${commit}
5	project = /summary/${project}
6	branch = /log/${project}/${branch}
7	filehistory = /blob/${project}/${branch}/${file}
8	linkname = gitblit
9	linkDrafts = false

Can those patterns be changed to pass query parameters? it'd be cleaner to parse the urls if project was delimited by something other than a slash, since it has slashes in the project path.

Example:

[gitweb]
    url = https://git.wikimedia.org
    type = custom
    revision = /r/commit/${commit}?project=${project}
    project = /r/${project}
    branch = /r/browse/${branch}?project=${project}
    filehistory = /r/browse/${branch}/${file}?project=${project}
    linkname = gitblit
    linkDrafts = false

Yeah I don't know why not.

It hasn't merged yet.

In D51#1491, @Paladox wrote:

It hasn't merged yet.

rPHEX34e5e748c6af7fcd4bb2382834df40ff246eddeb