Plugins: Simplify error output a bit
ClosedPublic

Authored by demon on Jan 3 2017, 8:44 PM.

Details

Reviewers
thcipriani
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCAc179539cb033: Plugins: Simplify error output a bit
Patch without arc
git checkout -b D527 && curl -L https://phabricator.wikimedia.org/D527?download=true | git apply
Summary

Right now we spit a full exception stacktrace, which is kinda ugly and makes a failure look worse than it is. Instead, just spit out the error type and error message.

Test Plan

Untested

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon retitled this revision from to Plugins: Simplify user output a bit.Jan 3 2017, 8:44 PM
demon updated this object.
demon edited the test plan for this revision. (Show Details)
demon added a reviewer: thcipriani.
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
thcipriani accepted this revision.Jan 3 2017, 8:50 PM
This revision is now accepted and ready to land.Jan 3 2017, 8:50 PM
demon retitled this revision from Plugins: Simplify user output a bit to Plugins: Simplify error output a bit.Jan 3 2017, 8:51 PM
demon updated the revert plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.

we should still log the exception details but at a higher logging level like debug

demon added a comment.Jan 4 2017, 6:25 AM

We can do that!