Defend against old proxies/canaries being defined
ClosedPublic

Authored by demon on Jan 5 2017, 8:45 PM.

Details

Reviewers
mmodell
Group Reviewers
Release-Engineering-Team
Commits
rMSCA5e10385473d2: Defend against old proxies/canaries being defined
Patch without arc
git checkout -b D530 && curl -L https://phabricator.wikimedia.org/D530?download=true | git apply
Summary

Right now, it's possible to depool/remove a node from the full sync list but leave it in the proxy/canary list. This is bad and will only lead to heartache.

Test Plan

Untested so far, felt like the right thing to do

Diff Detail

Repository
rMSCA Scap
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
demon retitled this revision from to Defend against old proxies/canaries being defined.Jan 5 2017, 8:45 PM
demon updated this object.
demon edited the test plan for this revision. (Show Details)
Restricted Application added a project: Release-Engineering-Team. · View Herald Transcript
mmodell accepted this revision.Jan 6 2017, 6:22 PM
This revision is now accepted and ready to land.Jan 6 2017, 6:22 PM
This revision was automatically updated to reflect the committed changes.