Puppet is not budging in allowing me to use an int so let's just make it a int.
This fixes prod for when we want to change versions too.
Change-Id: I348d674762953433bd77c6ff8efb4246d5d68b73
Details
Details
- Maniphest Tasks
- T155299: Phabricator: Support elasticsearch 5.x
- Reviewers
mmodell Dzahn - Patch without arc
- git checkout -b D562 && curl -L https://phabricator.wikimedia.org/D562?download=true | git apply
Diff Detail
Diff Detail
- Repository
- rPHAB Phabricator
- Branch
- wmf/stable
- Lint
Lint Passed - Unit
Tests Skipped - Build Status
Buildable 1601 Build 2558: differential-jessie Jenkins Build 2557: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/436/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/436/console
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/437/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/437/console
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/438/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/438/console
Comment Actions
Ok changing the type causes a setup warning "Config 'search.elastic.version' Invalid" but it doesn't break the code so this is an acceptable solution. This allows us to fix the config and the code without doing so in an atomic operation.
Comment Actions
@mmodell would you be able to land this please? This should fix the error you describe as puppet is not putting strings around an int. :)