Page MenuHomePhabricator
Differential D563

Fix setup warning on elasticsearch 5.0
ClosedPublic
Actions

Authored by mmodell on Feb 10 2017, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 31, 1:25 AM
Unknown Object (File)
Dec 7 2022, 4:49 AM
Unknown Object (File)
Apr 12 2017, 10:06 AM
Unknown Object (File)
Apr 12 2017, 10:05 AM
Unknown Object (File)
Apr 12 2017, 10:05 AM
Unknown Object (File)
Apr 5 2017, 9:49 PM
Unknown Object (File)
Mar 30 2017, 1:33 PM
Unknown Object (File)
Mar 29 2017, 1:46 AM
View All 13 Files
Subscribers
jenkins

Details

Maniphest Tasks
T155299: Phabricator: Support elasticsearch 5.x
Reviewers
Paladox
• MZMcBride
EBernhardson
Patch without arc
git checkout -b D563 && curl -L https://phabricator.wikimedia.org/D563?download=true | git apply
Summary

This Improves ElasticSearch 5.0 compatibility and fixes the
setup check to properly detect missing index & outdated mappings
without false positive on ElasticSearch 5+

Test Plan

Tested with es 5.2:

  • bin/search init
  • bin/search index
  • execute some test queries in phabricator

Not tested:

  • es 2.x support

Diff Detail

Event Timeline

mmodell created this revision.Feb 10 2017, 9:43 PM
Harbormaster failed remote builds in B1602: Diff 1490!Feb 10 2017, 9:43 PM
jenkins added a subscriber: jenkins.Feb 10 2017, 9:44 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/439/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/439/console

mmodell added a task: T155299: Phabricator: Support elasticsearch 5.x.Feb 10 2017, 9:45 PM
Paladox accepted this revision.Feb 10 2017, 9:49 PM

Yay that fixed it, thanks :)

This revision is now accepted and ready to land.Feb 10 2017, 9:49 PM
Paladox added a comment.Feb 10 2017, 9:49 PM

Deployed on phab-01 and it works :)

mmodell updated this revision to Diff 1491.Feb 10 2017, 9:51 PM

use old style php array syntax to make lint happy

Harbormaster failed remote builds in B1603: Diff 1491!Feb 10 2017, 9:51 PM
jenkins added a comment.Feb 10 2017, 9:51 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/440/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/440/console

mmodell closed this revision.Feb 10 2017, 9:53 PM

Revision Contents
Changeset List

PathSize
src/
applications/
search/
fulltextstorage/
25 lines

Diff 1490

View Options

src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL