This Improves ElasticSearch 5.0 compatibility and fixes the
setup check to properly detect missing index & outdated mappings
without false positive on ElasticSearch 5+
Details
Details
- Maniphest Tasks
- T155299: Phabricator: Support elasticsearch 5.x
- Reviewers
Paladox • MZMcBride EBernhardson - Patch without arc
- git checkout -b D563 && curl -L https://phabricator.wikimedia.org/D563?download=true | git apply
Tested with es 5.2:
- bin/search init
- bin/search index
- execute some test queries in phabricator
Not tested:
- es 2.x support
Diff Detail
Diff Detail
- Repository
- rPHAB Phabricator
- Branch
- es5 (branched from wmf/stable)
- Lint
Lint Errors Severity Location Code Message Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:123 XHP45 PHP Compatibility Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:226 XHP45 PHP Compatibility Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:227 XHP45 PHP Compatibility Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:229 XHP45 PHP Compatibility Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:240 XHP45 PHP Compatibility Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:241 XHP45 PHP Compatibility Error src/applications/search/fulltextstorage/PhabricatorElasticFulltextStorageEngine.php:400 XHP45 PHP Compatibility - Unit
Tests Passed - Build Status
Buildable 1602 Build 2560: differential-jessie Jenkins Build 2559: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/439/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/439/console
Comment Actions
Build has FAILED
Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/440/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/440/console