Page MenuHomePhabricator

build: Remove npm grunt-jsonlint package & update others
AcceptedPublic

Authored by Volker_E on May 21 2017, 11:34 AM.

Details

Reviewers
Jdrewniak
Prtksxna
Commits
rWMUI013cf2bc7e6e: build: Remove npm grunt-jsonlint package & update others
Patch without arc
git checkout -b D648 && curl -L https://phabricator.wikimedia.org/D648?download=true | git apply
Summary

Removing npm 'grunt-jsonlint' package,
integrating 'stylelint' explicitly and
updating 'grunt-stylelint' to v0.8.0

Bug: T165652

Diff Detail

Repository
rWMUI WikimediaUI Base
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Volker_E created this revision.May 21 2017, 11:34 AM
Jdrewniak requested changes to this revision.May 21 2017, 11:37 AM
Jdrewniak added inline comments.
package.json
18–19

looks like 'grunt-jsonlint' is still here

This revision now requires changes to proceed.May 21 2017, 11:37 AM
Volker_E updated this revision to Diff 1706.May 21 2017, 11:46 AM
Volker_E edited edge metadata.

build: Remove npm grunt-jsonlint package & update others

Volker_E marked an inline comment as done.May 21 2017, 11:48 AM
Jdrewniak accepted this revision.May 21 2017, 11:49 AM
This revision is now accepted and ready to land.May 21 2017, 11:49 AM
This revision was automatically updated to reflect the committed changes.
Prtksxna reopened this revision.May 22 2017, 1:33 AM
Prtksxna edited edge metadata.

We need to remove this task from the Gruntfile as well - https://phabricator.wikimedia.org/source/wikimedia-ui-base/browse/master/Gruntfile.js;013cf2bc7e6ebe819d5297bb6886b3d6bec9d02b$14. With the package removed grunt will complain.

This revision is now accepted and ready to land.May 22 2017, 1:33 AM

@Prtksxna This revision is now accepted and ready to land.

Not sure how that happened.