Fix Exception Rejecting ambiguous URI
AbandonedPublic
Actions

Authored by Paladox on Jun 4 2017, 12:05 PM.

Details

Reviewers

mmodell

Patch without arc

git checkout -b D673 && curl -L https://phabricator.wikimedia.org/D673?download=true | git apply

Summary

if preg matches (^[^/:]*://[^/]*[#?].*:) then return '' to prevent it from making it a link but also to prevent a task from being prevented from loading.

Tested on https://phab-01.wmflabs.org/T145#2949

Bug: T166958
Change-Id: Ia74e357a09d9a5ccea829a4321c48bbb6033bebd

Diff Detail

Repository

rPHUTIL libphutil

Branch

wmf/stable

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 1878
Build 3052: arc lint + arc unit

Event Timeline

Paladox created this revision.Jun 4 2017, 12:05 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptJun 4 2017, 12:05 PM

Paladox added a task: T166958: Unhandled exception on viewing T14974.Jun 4 2017, 12:06 PM

Paladox added a task: T166870: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc.Jun 4 2017, 12:16 PM

Instead of hyperlinking it will just return it as plain text. Better then throwing an error.

Paladox removed a task: T166870: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc.Jun 6 2017, 3:33 PM

See https://phabricator.wikimedia.org/D679

Paladox removed a task: T166958: Unhandled exception on viewing T14974.Jun 6 2017, 3:36 PM

Revision Contents
Changeset List

Path

Size

src/

parser/

PhutilURI.php

6 lines

Diff 1765

View Options

Fix Exception Rejecting ambiguous URIAbandonedPublicActions