Fallback to plain text if we carn't make the text a hyperlink
AbandonedPublic
Actions

Authored by Paladox on Jun 6 2017, 3:35 PM.

Details

Maniphest Tasks

T166870: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc

Reviewers

mmodell

Patch without arc

git checkout -b D679 && curl -L https://phabricator.wikimedia.org/D679?download=true | git apply

Summary

Following how it was done for https://secure.phabricator.com/rPHU13662252b7545db27b3d5ecc1f1fdf55f38f90fe

Tested on phab-01 and works.

Change-Id: Ia8a9feb959c2ed957757437cf972d53ea9746abe

Diff Detail

Repository

rPHUTIL libphutil

Branch

wmf/stable

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Paladox created this revision.Jun 6 2017, 3:35 PM

Restricted Application added a reviewer: mmodell. · View Herald TranscriptJun 6 2017, 3:35 PM

Paladox added a task: T166958: Unhandled exception on viewing T14974.Jun 6 2017, 3:36 PM

Probably want to also upstream this fix :)

Paladox mentioned this in T166958: Unhandled exception on viewing T14974.Jun 6 2017, 5:40 PM

Dzahn mentioned this in T167243: phabricator exception on T163283.Jun 7 2017, 12:38 AM

Aklapper edited tasks, added T166870: "Unhandled Exception ("Exception"): Rejecting ambiguous URI" when trying to access certain tasks / conpherence rooms / etc; removed T166958: Unhandled exception on viewing T14974.Jun 7 2017, 9:02 AM

Paladox abandoned this revision.Jun 17 2017, 3:15 PM

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

remarkup/

markuprule/

PhutilRemarkupHyperlinkRule.php

12 lines

Diff 1772

View Options

src/markup/engine/remarkup/markuprule/PhutilRemarkupHyperlinkRule.php

Fallback to plain text if we carn't make the text a hyperlinkAbandonedPublicActions