Allow dashboard panels to be found by monogram
AbandonedPublic
Actions

Authored by mmodell on Jun 12 2017, 4:02 PM.

Details

Maniphest Tasks

T166236: Clicking "Add Existing Panel" and entering `Wxxx` in the field shows no results

Reviewers

Paladox

Patch without arc

git checkout -b D683 && curl -L https://phabricator.wikimedia.org/D683?download=true | git apply

Summary

Just add the monogram to the datasource field. Fixes T166236

Test Plan

tested locally on my dev phab.

Diff Detail

Repository

rPHAB Phabricator

Branch

wmf/stable

Lint

Lint OK

Unit

Unit Tests OK

Build Status

Buildable 1899
Build 3086: differential-jessie	Jenkins
Build 3085: arc lint + arc unit

Event Timeline

mmodell created this revision.Jun 12 2017, 4:02 PM

Build has FAILED

Link to build: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/575/
See console output for more information: https://integration.wikimedia.org/ci/job/phabricator-jessie-diffs/575/console

Harbormaster failed remote builds in B1899: Diff 1782!Jun 12 2017, 4:03 PM

Paladox accepted this revision.Jun 13 2017, 9:28 PM

This revision is now accepted and ready to land.Jun 13 2017, 9:28 PM

I got this change accepted upstream, so no need for it here, I'll deploy the upstream commit this week.

Revision Contents
Changeset List

Path

Size

src/

applications/

dashboard/

typeahead/

PhabricatorDashboardPanelDatasource.php

2 lines

Diff 1782

View Options

src/applications/dashboard/typeahead/PhabricatorDashboardPanelDatasource.php

Allow dashboard panels to be found by monogramAbandonedPublicActions